diff options
| author | Andrew Pinski <andrew_pinski@playstation.sony.com> | 2007-05-28 19:43:10 +0000 |
|---|---|---|
| committer | Andrew Pinski <pinskia@gcc.gnu.org> | 2007-05-28 12:43:10 -0700 |
| commit | 3613c7abfa4392fd47d5078eb2261ad763772d2e (patch) | |
| tree | 115b6795f44871b452f47fbbb8f7221a4041f1d5 | |
| parent | 3366c30b7fc1404833d54aaeb54de57ca7a16e16 (diff) | |
| download | gcc-3613c7abfa4392fd47d5078eb2261ad763772d2e.zip gcc-3613c7abfa4392fd47d5078eb2261ad763772d2e.tar.gz gcc-3613c7abfa4392fd47d5078eb2261ad763772d2e.tar.bz2 | |
re PR tree-optimization/32100 (vrp bitfield miscompilation)
2007-05-28 Andrew Pinski <andrew_pinski@playstation.sony.com>
PR tree-opt/32100
* fold-const.c (tree_expr_nonnegative_warnv_p): Don't
return true when truth_value_p is true and the type
is of signed:1.
2007-05-28 Andrew Pinski <andrew_pinski@playstation.sony.com>
PR tree-opt/32100
* gcc.c-torture/execute/vrp-7.c: New test.
From-SVN: r125139
| -rw-r--r-- | gcc/ChangeLog | 7 | ||||
| -rw-r--r-- | gcc/fold-const.c | 11 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.c-torture/execute/vrp-7.c | 20 |
4 files changed, 40 insertions, 3 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index db6a377..0b34249 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2007-05-28 Andrew Pinski <andrew_pinski@playstation.sony.com> + + PR tree-opt/32100 + * fold-const.c (tree_expr_nonnegative_warnv_p): Don't + return true when truth_value_p is true and the type + is of signed:1. + 2007-05-28 Gerald Pfeifer <gerald@pfeifer.com> * doc/install.texi (Prerequisites): We no longer require Autoconf diff --git a/gcc/fold-const.c b/gcc/fold-const.c index 16dfd3b..01ce961 100644 --- a/gcc/fold-const.c +++ b/gcc/fold-const.c @@ -13485,9 +13485,14 @@ tree_expr_nonnegative_warnv_p (tree t, bool *strict_overflow_p) /* ... fall through ... */ default: - if (truth_value_p (TREE_CODE (t))) - /* Truth values evaluate to 0 or 1, which is nonnegative. */ - return true; + { + tree type = TREE_TYPE (t); + if ((TYPE_PRECISION (type) != 1 || TYPE_UNSIGNED (type)) + && truth_value_p (TREE_CODE (t))) + /* Truth values evaluate to 0 or 1, which is nonnegative unless we + have a signed:1 type (where the value is -1 and 0). */ + return true; + } } /* We don't know sign of `t', so be conservative and return false. */ diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 86111bf..2e546eb 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2007-05-28 Andrew Pinski <andrew_pinski@playstation.sony.com> + + PR tree-opt/32100 + * gcc.c-torture/execute/vrp-7.c: New test. + 2007-05-28 Brooks Moses <brooks.moses@codesourcery.com> * gfortran.dg/transfer_simplify_4.f90: New test. diff --git a/gcc/testsuite/gcc.c-torture/execute/vrp-7.c b/gcc/testsuite/gcc.c-torture/execute/vrp-7.c new file mode 100644 index 0000000..b4c9e62 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/execute/vrp-7.c @@ -0,0 +1,20 @@ + +void abort (void); + +struct T +{ + int b : 1; +} t; + +void __attribute__((noinline)) foo (int f) +{ + t.b = (f & 0x10) ? 1 : 0; +} + +int main (void) +{ + foo (0x10); + if (!t.b) + abort (); + return 0; +} |