diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2022-09-06 09:21:10 +0200 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2022-09-06 09:23:40 +0200 |
| commit | 1bf8b7adc2de6f2ddaffa3af131b6855ae3e3793 (patch) | |
| tree | 816196f88a6aa7020a272147fcf97d5a0163efbc | |
| parent | bc1bc808d860c013318a3f126dc69cb894cb3e11 (diff) | |
| download | gcc-1bf8b7adc2de6f2ddaffa3af131b6855ae3e3793.zip gcc-1bf8b7adc2de6f2ddaffa3af131b6855ae3e3793.tar.gz gcc-1bf8b7adc2de6f2ddaffa3af131b6855ae3e3793.tar.bz2 | |
openmp: Fix ICE when splitting invalid depend(source)/depend(sink:vec)
As we now create OMP_CLAUSE_DOACROSS rather than OMP_CLAUSE_DEPEND when
depend is used with source/sink modifiers, c_omp_split_clauses can see
OMP_CLAUSE_DOACROSS clause too before we diagnose it as erroneous.
The following patch treats it like OMP_CLAUSE_DEPEND during
the splitting but adds an assertion.
2022-09-06 Jakub Jelinek <jakub@redhat.com>
PR c/106836
* c-omp.cc (c_omp_split_clauses): Handle OMP_CLAUSE_DOACROSS.
* c-c++-common/gomp/pr106836.c: New test.
| -rw-r--r-- | gcc/c-family/c-omp.cc | 6 | ||||
| -rw-r--r-- | gcc/testsuite/c-c++-common/gomp/pr106836.c | 9 |
2 files changed, 15 insertions, 0 deletions
diff --git a/gcc/c-family/c-omp.cc b/gcc/c-family/c-omp.cc index 56bc4b1..1b086d8 100644 --- a/gcc/c-family/c-omp.cc +++ b/gcc/c-family/c-omp.cc @@ -1877,6 +1877,12 @@ c_omp_split_clauses (location_t loc, enum tree_code code, case OMP_CLAUSE_DEPEND: s = C_OMP_CLAUSE_SPLIT_TARGET; break; + case OMP_CLAUSE_DOACROSS: + /* This can happen with invalid depend(source) or + depend(sink:vec) on target combined with other constructs. */ + gcc_assert (OMP_CLAUSE_DOACROSS_DEPEND (clauses)); + s = C_OMP_CLAUSE_SPLIT_TARGET; + break; case OMP_CLAUSE_NUM_TEAMS: s = C_OMP_CLAUSE_SPLIT_TEAMS; break; diff --git a/gcc/testsuite/c-c++-common/gomp/pr106836.c b/gcc/testsuite/c-c++-common/gomp/pr106836.c new file mode 100644 index 0000000..6df8250 --- /dev/null +++ b/gcc/testsuite/c-c++-common/gomp/pr106836.c @@ -0,0 +1,9 @@ +/* PR c/106836 */ + +void +foo (void) +{ +#pragma omp target parallel depend (source) /* { dg-error "'depend\\\(source\\\)' is only allowed in 'omp ordered'" } */ + ; +#pragma omp taskwait +} |