diff options
| author | Richard Sandiford <richard.sandiford@arm.com> | 2024-01-25 12:03:18 +0000 |
|---|---|---|
| committer | Richard Sandiford <richard.sandiford@arm.com> | 2024-01-25 12:03:18 +0000 |
| commit | c3de14ba1ba0e77254118af64ed881f115ee42a0 (patch) | |
| tree | 1cdb6a4f19dd5e12eae559a49269978bdaab8d6f | |
| parent | 8eead1148cd0ac086b39a7abccea404041c85cb5 (diff) | |
| download | gcc-c3de14ba1ba0e77254118af64ed881f115ee42a0.zip gcc-c3de14ba1ba0e77254118af64ed881f115ee42a0.tar.gz gcc-c3de14ba1ba0e77254118af64ed881f115ee42a0.tar.bz2 | |
aarch64: Fix out-of-bounds ENCODED_ELT access [PR113572]
When generalising vector_cst_all_same, I'd forgotten to update
VECTOR_CST_ENCODED_ELT to VECTOR_CST_ELT. The check deliberately
looks at implicitly encoded elements in some cases.
gcc/
PR target/113572
* config/aarch64/aarch64-sve-builtins.cc (vector_cst_all_same):
Check VECTOR_CST_ELT instead of VECTOR_CST_ENCODED_ELT
gcc/testsuite/
PR target/113572
* gcc.target/aarch64/sve/pr113572.c: New test.
| -rw-r--r-- | gcc/config/aarch64/aarch64-sve-builtins.cc | 2 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/aarch64/sve/pr113572.c | 12 |
2 files changed, 13 insertions, 1 deletions
diff --git a/gcc/config/aarch64/aarch64-sve-builtins.cc b/gcc/config/aarch64/aarch64-sve-builtins.cc index c2f1486..11f5c5c 100644 --- a/gcc/config/aarch64/aarch64-sve-builtins.cc +++ b/gcc/config/aarch64/aarch64-sve-builtins.cc @@ -3474,7 +3474,7 @@ vector_cst_all_same (tree v, unsigned int step) unsigned int nelts = lcm * VECTOR_CST_NELTS_PER_PATTERN (v); tree first_el = VECTOR_CST_ENCODED_ELT (v, 0); for (unsigned int i = 0; i < nelts; i += step) - if (!operand_equal_p (VECTOR_CST_ENCODED_ELT (v, i), first_el, 0)) + if (!operand_equal_p (VECTOR_CST_ELT (v, i), first_el, 0)) return false; return true; diff --git a/gcc/testsuite/gcc.target/aarch64/sve/pr113572.c b/gcc/testsuite/gcc.target/aarch64/sve/pr113572.c new file mode 100644 index 0000000..a5e6b7e --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/sve/pr113572.c @@ -0,0 +1,12 @@ +#include <arm_sve.h> + +uint64_t u; +struct S { int i; } he; + +void +foo () +{ + svuint64_t vld_clz = svld1_u64 (svwhilelt_b64 (0, 4), (uint64_t *) &he); + vld_clz = svclz_u64_z (svwhilelt_b64 (0, 1), vld_clz); + svst1_u64 (svwhilelt_b64 (0, 1), &u, vld_clz); +} |