diff options
| author | Jiahao Xu <xujiahao@loongson.cn> | 2024-01-24 17:19:13 +0800 |
|---|---|---|
| committer | Lulu Cheng <chenglulu@loongson.cn> | 2024-01-25 15:50:24 +0800 |
| commit | 77159546b2848b61159ac49882f7b1144e62eaaa (patch) | |
| tree | e781dd262dbad0e9b82e1d079eb00cebc360c19e | |
| parent | 578c7b91f418ebbef1bf169117815409e06f5197 (diff) | |
| download | gcc-77159546b2848b61159ac49882f7b1144e62eaaa.zip gcc-77159546b2848b61159ac49882f7b1144e62eaaa.tar.gz gcc-77159546b2848b61159ac49882f7b1144e62eaaa.tar.bz2 | |
LoongArch: Remove vec_concatz<mode> pattern.
It is incorrect to use vld/vori to implement the vec_concatz<mode> because when the LSX
instruction is used to update the value of the vector register, the upper 128 bits of
the vector register will not be zeroed.
gcc/ChangeLog:
* config/loongarch/lasx.md (@vec_concatz<mode>): Remove this define_insn pattern.
* config/loongarch/loongarch.cc (loongarch_expand_vector_group_init): Use vec_concat<mode>.
| -rw-r--r-- | gcc/config/loongarch/lasx.md | 15 | ||||
| -rw-r--r-- | gcc/config/loongarch/loongarch.cc | 17 |
2 files changed, 6 insertions, 26 deletions
diff --git a/gcc/config/loongarch/lasx.md b/gcc/config/loongarch/lasx.md index 72f7161..5d478b9 100644 --- a/gcc/config/loongarch/lasx.md +++ b/gcc/config/loongarch/lasx.md @@ -582,21 +582,6 @@ [(set_attr "type" "simd_insert") (set_attr "mode" "<MODE>")]) -(define_insn "@vec_concatz<mode>" - [(set (match_operand:LASX 0 "register_operand" "=f") - (vec_concat:LASX - (match_operand:<VHMODE256_ALL> 1 "nonimmediate_operand") - (match_operand:<VHMODE256_ALL> 2 "const_0_operand")))] - "ISA_HAS_LASX" -{ - if (MEM_P (operands[1])) - return "vld\t%w0,%1"; - else - return "vori.b\t%w0,%w1,0"; -} - [(set_attr "type" "simd_splat") - (set_attr "mode" "<MODE>")]) - (define_insn "vec_concat<mode>" [(set (match_operand:LASX 0 "register_operand" "=f") (vec_concat:LASX diff --git a/gcc/config/loongarch/loongarch.cc b/gcc/config/loongarch/loongarch.cc index da22fd6..dba1252 100644 --- a/gcc/config/loongarch/loongarch.cc +++ b/gcc/config/loongarch/loongarch.cc @@ -9917,17 +9917,12 @@ loongarch_expand_vector_group_init (rtx target, rtx vals) gcc_unreachable (); } - if (high == CONST0_RTX (half_mode)) - emit_insn (gen_vec_concatz (vmode, target, low, high)); - else - { - if (!register_operand (low, half_mode)) - low = force_reg (half_mode, low); - if (!register_operand (high, half_mode)) - high = force_reg (half_mode, high); - emit_insn (gen_rtx_SET (target, - gen_rtx_VEC_CONCAT (vmode, low, high))); - } + if (!register_operand (low, half_mode)) + low = force_reg (half_mode, low); + if (!register_operand (high, half_mode)) + high = force_reg (half_mode, high); + emit_insn (gen_rtx_SET (target, + gen_rtx_VEC_CONCAT (vmode, low, high))); } /* Expand initialization of a vector which has all same elements. */ |