diff options
author | Richard Sandiford <richard.sandiford@arm.com> | 2021-08-03 13:00:46 +0100 |
---|---|---|
committer | Richard Sandiford <richard.sandiford@arm.com> | 2021-08-03 13:00:46 +0100 |
commit | 537afb0857c8f60c2b60a09fad4660420cd13e8f (patch) | |
tree | 0b4dbd4d9ccad0cb3f10c76b9f24f8bdd8dbf375 | |
parent | 78770e0e5d9fef70679e1db4eb2fb06596fbb2f8 (diff) | |
download | gcc-537afb0857c8f60c2b60a09fad4660420cd13e8f.zip gcc-537afb0857c8f60c2b60a09fad4660420cd13e8f.tar.gz gcc-537afb0857c8f60c2b60a09fad4660420cd13e8f.tar.bz2 |
aarch64: Tweak the cost of elementwise stores
When the vectoriser scalarises a strided store, it counts one
scalar_store for each element plus one vec_to_scalar extraction
for each element. However, extracting element 0 is free on AArch64,
so it should have zero cost.
I don't have a testcase that requires this for existing -mtune
options, but it becomes more important with a later patch.
gcc/
* config/aarch64/aarch64.c (aarch64_is_store_elt_extraction): New
function, split out from...
(aarch64_detect_vector_stmt_subtype): ...here.
(aarch64_add_stmt_cost): Treat extracting element 0 as free.
-rw-r--r-- | gcc/config/aarch64/aarch64.c | 22 |
1 files changed, 19 insertions, 3 deletions
diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 36f1180..084f8ca 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -14622,6 +14622,18 @@ aarch64_builtin_vectorization_cost (enum vect_cost_for_stmt type_of_cost, } } +/* Return true if an operaton of kind KIND for STMT_INFO represents + the extraction of an element from a vector in preparation for + storing the element to memory. */ +static bool +aarch64_is_store_elt_extraction (vect_cost_for_stmt kind, + stmt_vec_info stmt_info) +{ + return (kind == vec_to_scalar + && STMT_VINFO_DATA_REF (stmt_info) + && DR_IS_WRITE (STMT_VINFO_DATA_REF (stmt_info))); +} + /* Return true if STMT_INFO represents part of a reduction. */ static bool aarch64_is_reduction (stmt_vec_info stmt_info) @@ -14959,9 +14971,7 @@ aarch64_detect_vector_stmt_subtype (vec_info *vinfo, vect_cost_for_stmt kind, /* Detect cases in which vec_to_scalar is describing the extraction of a vector element in preparation for a scalar store. The store itself is costed separately. */ - if (kind == vec_to_scalar - && STMT_VINFO_DATA_REF (stmt_info) - && DR_IS_WRITE (STMT_VINFO_DATA_REF (stmt_info))) + if (aarch64_is_store_elt_extraction (kind, stmt_info)) return simd_costs->store_elt_extra_cost; /* Detect SVE gather loads, which are costed as a single scalar_load @@ -15382,6 +15392,12 @@ aarch64_add_stmt_cost (class vec_info *vinfo, void *data, int count, if (vectype && aarch64_sve_only_stmt_p (stmt_info, vectype)) costs->saw_sve_only_op = true; + /* If we scalarize a strided store, the vectorizer costs one + vec_to_scalar for each element. However, we can store the first + element using an FP store without a separate extract step. */ + if (aarch64_is_store_elt_extraction (kind, stmt_info)) + count -= 1; + stmt_cost = aarch64_detect_scalar_stmt_subtype (vinfo, kind, stmt_info, stmt_cost); |