diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2024-03-26 11:06:15 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2024-03-26 11:13:24 +0100 |
| commit | 471967ab8b4c49338ba77defbe24b06cc51c0093 (patch) | |
| tree | d1f54ebf6d17e64ab503d2ba42af598913aa17b7 | |
| parent | f4e92d62dccb96ade753f3a8f49be1b5f61c31f1 (diff) | |
| download | gcc-471967ab8b4c49338ba77defbe24b06cc51c0093.zip gcc-471967ab8b4c49338ba77defbe24b06cc51c0093.tar.gz gcc-471967ab8b4c49338ba77defbe24b06cc51c0093.tar.bz2 | |
tsan: Don't instrument non-generic AS accesses [PR111736]
Similar to the asan and ubsan changes, we shouldn't instrument non-generic
address space accesses with tsan, because we just have library functions
which take address of the objects as generic address space pointers, so they
can't handle anything else.
2024-03-26 Jakub Jelinek <jakub@redhat.com>
PR sanitizer/111736
* tsan.cc (instrument_expr): Punt on non-generic address space
accesses.
* gcc.dg/tsan/pr111736.c: New test.
| -rw-r--r-- | gcc/testsuite/gcc.dg/tsan/pr111736.c | 17 | ||||
| -rw-r--r-- | gcc/tsan.cc | 3 |
2 files changed, 20 insertions, 0 deletions
diff --git a/gcc/testsuite/gcc.dg/tsan/pr111736.c b/gcc/testsuite/gcc.dg/tsan/pr111736.c new file mode 100644 index 0000000..34ab88b --- /dev/null +++ b/gcc/testsuite/gcc.dg/tsan/pr111736.c @@ -0,0 +1,17 @@ +/* PR sanitizer/111736 */ +/* { dg-do compile { target i?86-*-* x86_64-*-* } } */ +/* { dg-options "-fsanitize=thread -fdump-tree-optimized -ffat-lto-objects" } */ +/* { dg-final { scan-tree-dump-not "__tsan_read" "optimized" } } */ +/* { dg-final { scan-tree-dump-not "__tsan_write" "optimized" } } */ + +#ifdef __x86_64__ +#define SEG __seg_fs +#else +#define SEG __seg_gs +#endif + +void +foo (int SEG *p, int SEG *q) +{ + *q = *p; +} diff --git a/gcc/tsan.cc b/gcc/tsan.cc index e73e1d3..590e97d 100644 --- a/gcc/tsan.cc +++ b/gcc/tsan.cc @@ -139,6 +139,9 @@ instrument_expr (gimple_stmt_iterator gsi, tree expr, bool is_write) if (TREE_READONLY (base) || (VAR_P (base) && DECL_HARD_REGISTER (base))) return false; + if (!ADDR_SPACE_GENERIC_P (TYPE_ADDR_SPACE (TREE_TYPE (base)))) + return false; + stmt = gsi_stmt (gsi); loc = gimple_location (stmt); rhs = is_vptr_store (stmt, expr, is_write); |