diff options
| author | Yang Yang <yangyang305@huawei.com> | 2020-04-14 19:42:23 +0000 |
|---|---|---|
| committer | Richard Biener <rguenther@suse.de> | 2020-04-14 16:02:31 +0200 |
| commit | f65cecabc32fe12b024253502af953e657e1a878 (patch) | |
| tree | d80cba380e95cde4d8d064c1a059037dc617adea | |
| parent | 438ffa2a8fac925b1bee8862fa15bc5380c0dffd (diff) | |
| download | gcc-f65cecabc32fe12b024253502af953e657e1a878.zip gcc-f65cecabc32fe12b024253502af953e657e1a878.tar.gz gcc-f65cecabc32fe12b024253502af953e657e1a878.tar.bz2 | |
PR tree-optimization/94574 - aarch64: ICE during GIMPLE pass:ccp
In this PR the testcase ICEs because a BIT_INSERT_EXPR whose replaced bits are
not fully inside the container is generated. A size check is added to avoid
this kind of ICE.
gcc/ChangeLog:
PR tree-optimization/94574
* tree-ssa.c (non_rewritable_lvalue_p): Add size check when analyzing
whether a vector-insert is rewritable using a BIT_INSERT_EXPR.
gcc/testsuite/ChangeLog:
PR tree-optimization/94574
* gcc.dg/pr94574.c: New test.
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/pr94574.c | 15 | ||||
| -rw-r--r-- | gcc/tree-ssa.c | 4 |
4 files changed, 29 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 343b52c..441dcab 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2020-04-14 Yang Yang <yangyang305@huawei.com> + + PR tree-optimization/94574 + * tree-ssa.c (non_rewritable_lvalue_p): Add size check when analyzing + whether a vector-insert is rewritable using a BIT_INSERT_EXPR. + 2020-04-14 H.J. Lu <hongjiu.lu@intel.com> PR target/94561 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index e7a8238..051dcb1 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2020-04-14 Yang Yang <yangyang305@huawei.com> + + PR tree-optimization/94574 + * gcc.dg/pr94574.c: New test. + 2020-04-14 H.J. Lu <hongjiu.lu@intel.com> PR target/94561 diff --git a/gcc/testsuite/gcc.dg/pr94574.c b/gcc/testsuite/gcc.dg/pr94574.c new file mode 100644 index 0000000..0d18bd8 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr94574.c @@ -0,0 +1,15 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -w -Wno-psabi" } */ + +typedef unsigned int v4si __attribute__((vector_size(16))); +typedef unsigned int v2si __attribute__((vector_size(8))); + +/* The aliasing is somewhat dubious here, but it must compile. */ + +v2si +foo (v4si v) +{ + v2si res; + *(v4si *) &res = v; + return res; +} diff --git a/gcc/tree-ssa.c b/gcc/tree-ssa.c index 344f32d..4f4ab2b 100644 --- a/gcc/tree-ssa.c +++ b/gcc/tree-ssa.c @@ -1543,7 +1543,9 @@ non_rewritable_lvalue_p (tree lhs) && known_gt (wi::to_poly_offset (TYPE_SIZE_UNIT (TREE_TYPE (decl))), mem_ref_offset (lhs)) && multiple_of_p (sizetype, TREE_OPERAND (lhs, 1), - TYPE_SIZE_UNIT (TREE_TYPE (lhs)))) + TYPE_SIZE_UNIT (TREE_TYPE (lhs))) + && known_ge (wi::to_poly_offset (TYPE_SIZE (TREE_TYPE (decl))), + wi::to_poly_offset (TYPE_SIZE (TREE_TYPE (lhs))))) { poly_uint64 lhs_bits, nelts; if (poly_int_tree_p (TYPE_SIZE (TREE_TYPE (lhs)), &lhs_bits) |