aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGabriel Dos Reis <gdr@integrable-solutions.net>2003-07-14 15:04:32 +0000
committerGabriel Dos Reis <gdr@gcc.gnu.org>2003-07-14 15:04:32 +0000
commitf19319dbdf17b98c1b3df97c2297bf3f72d83c85 (patch)
tree25d7e15fa5d42bf5e8df97ae622cab9f43f20d77
parentc573d965f95aa51fbbf1cd7df87026f38fbed1c9 (diff)
downloadgcc-f19319dbdf17b98c1b3df97c2297bf3f72d83c85.zip
gcc-f19319dbdf17b98c1b3df97c2297bf3f72d83c85.tar.gz
gcc-f19319dbdf17b98c1b3df97c2297bf3f72d83c85.tar.bz2
re PR c++/5293 (confusing message when binding a temporary to a reference)
PR c++/5293 * call.c (initialize_reference): Improve diagnostic. From-SVN: r69332
-rw-r--r--gcc/cp/ChangeLog5
-rw-r--r--gcc/cp/call.c8
-rw-r--r--gcc/testsuite/g++.dg/init/ref8.C10
3 files changed, 22 insertions, 1 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 8cc0234..2627e94 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,8 @@
+2003-07-14 Gabriel Dos Reis <gdr@integrable-solutions.net>
+
+ PR c++/5293
+ * call.c (initialize_reference): Improve diagnostic.
+
2003-07-14 Kriang Lerdsuwanakij <lerdsuwa@users.sourceforge.net>
PR c++/11154
diff --git a/gcc/cp/call.c b/gcc/cp/call.c
index 39f8221..c71b3f8 100644
--- a/gcc/cp/call.c
+++ b/gcc/cp/call.c
@@ -6035,7 +6035,13 @@ initialize_reference (tree type, tree expr, tree decl)
conv = reference_binding (type, TREE_TYPE (expr), expr, LOOKUP_NORMAL);
if (!conv || ICS_BAD_FLAG (conv))
{
- error ("could not convert `%E' to `%T'", expr, type);
+ if (!(TYPE_QUALS (TREE_TYPE (type)) & TYPE_QUAL_CONST)
+ && !real_lvalue_p (expr))
+ error ("invalid initialization of non-const reference of "
+ "type '%T' from a temporary of type '%T'",
+ type, TREE_TYPE (expr));
+ else
+ error ("could not convert `%E' to `%T'", expr, type);
return error_mark_node;
}
diff --git a/gcc/testsuite/g++.dg/init/ref8.C b/gcc/testsuite/g++.dg/init/ref8.C
new file mode 100644
index 0000000..406cc10
--- /dev/null
+++ b/gcc/testsuite/g++.dg/init/ref8.C
@@ -0,0 +1,10 @@
+struct A {
+ A operator=(const A&);
+};
+
+A operator*(A, A);
+
+A& operator+=(A& a, const A& b)
+{
+ return a = a * b; // { dg-error "non-const reference" }
+}