diff options
| author | Jeff Law <law@gcc.gnu.org> | 1995-01-28 11:55:00 -0700 |
|---|---|---|
| committer | Jeff Law <law@gcc.gnu.org> | 1995-01-28 11:55:00 -0700 |
| commit | da6f15cdef9251ed945e2435e12aa3713cf0d808 (patch) | |
| tree | c634df7e50f5463a6f9216ac1b17e3b2b45f6fc9 | |
| parent | 8e6c802b46eeadb19407635dcc53bd8cafdd54ff (diff) | |
| download | gcc-da6f15cdef9251ed945e2435e12aa3713cf0d808.zip gcc-da6f15cdef9251ed945e2435e12aa3713cf0d808.tar.gz gcc-da6f15cdef9251ed945e2435e12aa3713cf0d808.tar.bz2 | |
pa.md (call, call_value): Always save the PIC register before a call.
* pa.md (call, call_value): Always save the PIC register before
a call.
From-SVN: r8836
| -rw-r--r-- | gcc/config/pa/pa.md | 40 |
1 files changed, 26 insertions, 14 deletions
diff --git a/gcc/config/pa/pa.md b/gcc/config/pa/pa.md index 7c2be01..62bd4e2 100644 --- a/gcc/config/pa/pa.md +++ b/gcc/config/pa/pa.md @@ -3426,13 +3426,19 @@ use_reg (&CALL_INSN_FUNCTION_USAGE (call_insn), pic_offset_table_rtx); if (!hppa_save_pic_table_rtx) - { - hppa_save_pic_table_rtx = gen_reg_rtx (Pmode); - emit_insn_before (gen_rtx (SET, VOIDmode, - hppa_save_pic_table_rtx, - pic_offset_table_rtx), - call_insn); - } + hppa_save_pic_table_rtx = gen_reg_rtx (Pmode); + + /* We must save and restore the PIC register around every call + since we don't have flow information to determine if this save + is redundant with a previous save. The old code assumed once + the register was saved it never needs to be saved again, but + the save could have been on a path which doesn't always + execute; a call site physically later in the program would + then attempt a restore from an uninitialized register! */ + emit_insn_before (gen_rtx (SET, VOIDmode, + hppa_save_pic_table_rtx, + pic_offset_table_rtx), + call_insn); emit_insn (gen_rtx (SET, VOIDmode, pic_offset_table_rtx, hppa_save_pic_table_rtx)); @@ -3522,13 +3528,19 @@ use_reg (&CALL_INSN_FUNCTION_USAGE (call_insn), pic_offset_table_rtx); if (!hppa_save_pic_table_rtx) - { - hppa_save_pic_table_rtx = gen_reg_rtx (Pmode); - emit_insn_before (gen_rtx (SET, VOIDmode, - hppa_save_pic_table_rtx, - pic_offset_table_rtx), - call_insn); - } + hppa_save_pic_table_rtx = gen_reg_rtx (Pmode); + + /* We must save and restore the PIC register around every call + since we don't have flow information to determine if this save + is redundant with a previous save. The old code assumed once + the register was saved it never needs to be saved again, but + the save could have been on a path which doesn't always + execute; a call site physically later in the program would + then attempt a restore from an uninitialized register! */ + emit_insn_before (gen_rtx (SET, VOIDmode, + hppa_save_pic_table_rtx, + pic_offset_table_rtx), + call_insn); emit_insn (gen_rtx (SET, VOIDmode, pic_offset_table_rtx, hppa_save_pic_table_rtx)); |