aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorH.J. Lu <hjl.tools@gmail.com>2020-08-26 12:37:05 -0700
committerH.J. Lu <hjl.tools@gmail.com>2020-08-26 12:56:18 -0700
commit8f1ea8ddccc34c28f72910d9f61bacd35cc73270 (patch)
tree65f014bee28aa0a57ed15c50ffc630a9876bd1b7
parent703e049aa72e01c15087750fe63deba779c9b2dd (diff)
downloadgcc-8f1ea8ddccc34c28f72910d9f61bacd35cc73270.zip
gcc-8f1ea8ddccc34c28f72910d9f61bacd35cc73270.tar.gz
gcc-8f1ea8ddccc34c28f72910d9f61bacd35cc73270.tar.bz2
x86: Reject target("no-general-regs-only")
Reject target("no-general-regs-only") pragma and attribute. gcc/ PR target/96802 * config/i386/i386-options.c (ix86_valid_target_attribute_inner_p): Reject target("no-general-regs-only"). gcc/testsuite/ PR target/96802 * gcc.target/i386/pr96802-1.c: New test. * gcc.target/i386/pr96802-2.c: Likewise.
-rw-r--r--gcc/config/i386/i386-options.c7
-rw-r--r--gcc/testsuite/gcc.target/i386/pr96802-1.c12
-rw-r--r--gcc/testsuite/gcc.target/i386/pr96802-2.c16
3 files changed, 35 insertions, 0 deletions
diff --git a/gcc/config/i386/i386-options.c b/gcc/config/i386/i386-options.c
index e0fc68c..b93c338 100644
--- a/gcc/config/i386/i386-options.c
+++ b/gcc/config/i386/i386-options.c
@@ -1189,6 +1189,13 @@ ix86_valid_target_attribute_inner_p (tree fndecl, tree args, char *p_strings[],
{
if (mask == OPTION_MASK_GENERAL_REGS_ONLY)
{
+ if (!opt_set_p)
+ {
+ error_at (loc, "pragma or attribute %<target(\"%s\")%> "
+ "does not allow a negated form", p);
+ return false;
+ }
+
if (type != ix86_opt_ix86_yes)
gcc_unreachable ();
diff --git a/gcc/testsuite/gcc.target/i386/pr96802-1.c b/gcc/testsuite/gcc.target/i386/pr96802-1.c
new file mode 100644
index 0000000..e6ceb95
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr96802-1.c
@@ -0,0 +1,12 @@
+/* { dg-do compile } */
+
+/* Reject the negated form of non-negatable attributes. */
+
+__attribute__ ((target ("no-general-regs-only")))
+int
+foo (int a)
+{
+ return a + 1;
+}
+
+/* { dg-error "does not allow a negated form" "" { target *-*-* } 0 } */
diff --git a/gcc/testsuite/gcc.target/i386/pr96802-2.c b/gcc/testsuite/gcc.target/i386/pr96802-2.c
new file mode 100644
index 0000000..515f567
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr96802-2.c
@@ -0,0 +1,16 @@
+/* { dg-do compile } */
+
+/* Reject the negated form of non-negatable pragma target. */
+
+#pragma GCC push_options
+#pragma GCC target("no-general-regs-only")
+
+int
+foo (int a)
+{
+ return a + 1;
+}
+
+#pragma GCC pop_options
+
+/* { dg-error "does not allow a negated form" "" { target *-*-* } 0 } */