diff options
| author | Paolo Carlini <paolo.carlini@oracle.com> | 2013-05-24 17:37:41 +0000 |
|---|---|---|
| committer | Paolo Carlini <paolo@gcc.gnu.org> | 2013-05-24 17:37:41 +0000 |
| commit | 7f5d76fb976770ec90deaf562ba7cf566bf9b0be (patch) | |
| tree | d61337f07687efcd2340ad1335a2c5ee0514ab86 | |
| parent | 2343af65585862c38ab76e78387c2ae60c93f227 (diff) | |
| download | gcc-7f5d76fb976770ec90deaf562ba7cf566bf9b0be.zip gcc-7f5d76fb976770ec90deaf562ba7cf566bf9b0be.tar.gz gcc-7f5d76fb976770ec90deaf562ba7cf566bf9b0be.tar.bz2 | |
re PR c++/19618 (Do warn if a bit-field exceeds the size of a bool type)
/cp
2013-05-24 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/19618
* class.c (check_bitfield_decl): Warn for bool and enum bitfields
with width exceeding the type.
/testsuite
2013-05-24 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/19618
* g++.dg/expr/bitfield12.C: New.
From-SVN: r199306
| -rw-r--r-- | gcc/cp/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/cp/class.c | 9 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/g++.dg/expr/bitfield12.C | 19 |
4 files changed, 36 insertions, 3 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 585ab73..7b02b8b 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2013-05-24 Paolo Carlini <paolo.carlini@oracle.com> + + PR c++/19618 + * class.c (check_bitfield_decl): Warn for bool and enum bitfields + with width exceeding the type. + 2013-05-24 Jason Merrill <jason@redhat.com> PR c++/57391 diff --git a/gcc/cp/class.c b/gcc/cp/class.c index 94ae567..d6684cf 100644 --- a/gcc/cp/class.c +++ b/gcc/cp/class.c @@ -3140,9 +3140,12 @@ check_bitfield_decl (tree field) error ("zero width for bit-field %q+D", field); w = error_mark_node; } - else if (compare_tree_int (w, TYPE_PRECISION (type)) > 0 - && TREE_CODE (type) != ENUMERAL_TYPE - && TREE_CODE (type) != BOOLEAN_TYPE) + else if ((TREE_CODE (type) != ENUMERAL_TYPE + && TREE_CODE (type) != BOOLEAN_TYPE + && compare_tree_int (w, TYPE_PRECISION (type)) > 0) + || ((TREE_CODE (type) == ENUMERAL_TYPE + || TREE_CODE (type) == BOOLEAN_TYPE) + && tree_int_cst_lt (TYPE_SIZE (type), w))) warning (0, "width of %q+D exceeds its type", field); else if (TREE_CODE (type) == ENUMERAL_TYPE && (0 > (compare_tree_int diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 8c2e293..a0278d5 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2013-05-24 Paolo Carlini <paolo.carlini@oracle.com> + + PR c++/19618 + * g++.dg/expr/bitfield12.C: New. + 2013-05-24 Jeff Law <law@redhat.com> PR tree-optimization/57124 diff --git a/gcc/testsuite/g++.dg/expr/bitfield12.C b/gcc/testsuite/g++.dg/expr/bitfield12.C new file mode 100644 index 0000000..3ae88ca --- /dev/null +++ b/gcc/testsuite/g++.dg/expr/bitfield12.C @@ -0,0 +1,19 @@ +// PR c++/19618 + +struct bset1 { + bool bit : sizeof(bool) * __CHAR_BIT__ + 1; // { dg-warning "exceeds" } +}; + +enum E {}; + +struct bset2 { + E bit : sizeof(E) * __CHAR_BIT__ + 1; // { dg-warning "exceeds" } +}; + +struct bset3 { + bool bit : sizeof(bool) * __CHAR_BIT__; +}; + +struct bset4 { + E bit : sizeof(E) * __CHAR_BIT__; +}; |