diff options
| author | Iain Sandoe <iain@sandoe.co.uk> | 2018-08-15 11:45:44 +0000 |
|---|---|---|
| committer | Iain Sandoe <iains@gcc.gnu.org> | 2018-08-15 11:45:44 +0000 |
| commit | 7273331429916a0c203b1064e0414c741c06a78f (patch) | |
| tree | 85d44fb86970e37b0e74a8cfc826e11d25919208 | |
| parent | 05c1e87adbc09a2c90155d5d5d05cf866d39c9e2 (diff) | |
| download | gcc-7273331429916a0c203b1064e0414c741c06a78f.zip gcc-7273331429916a0c203b1064e0414c741c06a78f.tar.gz gcc-7273331429916a0c203b1064e0414c741c06a78f.tar.bz2 | |
Don't make unsized objects into extern.
2018-08-15 Iain Sandoe <iain@sandoe.co.uk>
gcc/c:
PR c/19315
* c-decl.c (finish_decl): Don't add the 'extern' storage class to
objects of unknown size.
gcc/testsuite:
PR c/19315
gcc.dg/graphite/pr82451.c: Make array 'a' an extern.
gcc.dg/redecl-10.c: Expect warnings for the static vars with unknown
size.
From-SVN: r263556
| -rw-r--r-- | gcc/c/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/c/c-decl.c | 8 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 7 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/graphite/pr82451.c | 2 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/redecl-10.c | 4 |
5 files changed, 16 insertions, 11 deletions
diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog index be2ffbd..5931206 100644 --- a/gcc/c/ChangeLog +++ b/gcc/c/ChangeLog @@ -1,3 +1,9 @@ +2018-08-15 Iain Sandoe <iain@sandoe.co.uk> + + PR c/19315 + * c-decl.c (finish_decl): Don't add the 'extern' storage class to + objects of unknown size. + 2018-08-13 Martin Sebor <msebor@redhat.com> PR tree-optimization/71625 diff --git a/gcc/c/c-decl.c b/gcc/c/c-decl.c index ed1dd28..da42add 100644 --- a/gcc/c/c-decl.c +++ b/gcc/c/c-decl.c @@ -4969,14 +4969,6 @@ finish_decl (tree decl, location_t init_loc, tree init, case 2: if (do_default) error ("array size missing in %q+D", decl); - /* If a `static' var's size isn't known, - make it extern as well as static, so it does not get - allocated. - If it is not `static', then do not mark extern; - finish_incomplete_decl will give it a default size - and it will get allocated. */ - else if (!pedantic && TREE_STATIC (decl) && !TREE_PUBLIC (decl)) - DECL_EXTERNAL (decl) = 1; break; case 3: diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 46a1627..18bb966 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2018-08-15 Iain Sandoe <iain@sandoe.co.uk> + + PR c/19315 + * gcc.dg/graphite/pr82451.c: Make array 'a' an extern. + * gcc.dg/redecl-10.c: Expect warnings for the static vars with + unknown size. + 2018-08-15 Martin Liska <mliska@suse.cz> PR tree-optimization/86925 diff --git a/gcc/testsuite/gcc.dg/graphite/pr82451.c b/gcc/testsuite/gcc.dg/graphite/pr82451.c index 802b931..b2c439b 100644 --- a/gcc/testsuite/gcc.dg/graphite/pr82451.c +++ b/gcc/testsuite/gcc.dg/graphite/pr82451.c @@ -1,7 +1,7 @@ /* { dg-do compile } */ /* { dg-options "-O -floop-parallelize-all" } */ -static int a[]; +extern int a[]; int b[1]; int c; static void diff --git a/gcc/testsuite/gcc.dg/redecl-10.c b/gcc/testsuite/gcc.dg/redecl-10.c index 525961e..0864311 100644 --- a/gcc/testsuite/gcc.dg/redecl-10.c +++ b/gcc/testsuite/gcc.dg/redecl-10.c @@ -5,7 +5,7 @@ /* { dg-do compile } */ /* { dg-options "-g" } */ -static int w[]; +static int w[]; /* { dg-warning "array 'w' assumed to have one element" } */ void f (void) { @@ -19,7 +19,7 @@ g (void) extern int x[] = { 3, 4, 5 }; /* { dg-error "has both" } */ } -static int y[]; +static int y[]; /* { dg-warning "array 'y' assumed to have one element" } */ void h (void) { |