diff options
| author | Stafford Horne <shorne@gmail.com> | 2019-07-21 21:02:54 +0000 |
|---|---|---|
| committer | Stafford Horne <shorne@gcc.gnu.org> | 2019-07-21 21:02:54 +0000 |
| commit | 575ce8934206f6884fe009916551ee221931565c (patch) | |
| tree | a3dda05ee246e99b847d2cafa4072e57e403793e | |
| parent | 44080af98edf7d8a59a94dd803f60cf0505fba34 (diff) | |
| download | gcc-575ce8934206f6884fe009916551ee221931565c.zip gcc-575ce8934206f6884fe009916551ee221931565c.tar.gz gcc-575ce8934206f6884fe009916551ee221931565c.tar.bz2 | |
or1k: only force reg for immediates
The force_reg in or1k_expand_compare is hard coded for SImode, which is fine as
this used to only be used on SI expands. However, with FP support this will
cause issues. In general we should only force the right hand operand to a
register if its an immediate. This patch adds an condition to check for that.
gcc/ChangeLog:
* config/or1k/or1k.c (or1k_expand_compare): Check for int before
force_reg.
From-SVN: r273651
| -rw-r--r-- | gcc/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/config/or1k/or1k.c | 10 |
2 files changed, 11 insertions, 4 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 224b785..711a31e 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,10 @@ 2019-07-22 Stafford Horne <shorne@gmail.com> + * config/or1k/or1k.c (or1k_expand_compare): Check for int before + force_reg. + +2019-07-22 Stafford Horne <shorne@gmail.com> + * config.gcc (or1k*-*-*): Add mhard-float, mdouble-float, msoft-float and munordered-float validations. * config/or1k/constraints.md (d): New register constraint. diff --git a/gcc/config/or1k/or1k.c b/gcc/config/or1k/or1k.c index 1eea84f..f8eed4a 100644 --- a/gcc/config/or1k/or1k.c +++ b/gcc/config/or1k/or1k.c @@ -1448,13 +1448,15 @@ void or1k_expand_compare (rtx *operands) { rtx sr_f = gen_rtx_REG (BImode, SR_F_REGNUM); + rtx righthand_op = XEXP (operands[0], 1); rtx_code cmp_code = GET_CODE (operands[0]); bool flag_check_ne = true; - /* The RTL may receive an immediate in argument 1 of the compare, this is not - supported unless we have l.sf*i instructions, force them into registers. */ - if (!TARGET_SFIMM) - XEXP (operands[0], 1) = force_reg (SImode, XEXP (operands[0], 1)); + /* Integer RTL may receive an immediate in argument 1 of the compare, this is + not supported unless we have l.sf*i instructions, force them into + registers. */ + if (!TARGET_SFIMM && CONST_INT_P (righthand_op)) + XEXP (operands[0], 1) = force_reg (SImode, righthand_op); /* Normalize comparison operators to ones OpenRISC support. */ switch (cmp_code) |