diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2012-09-25 14:46:54 +0200 |
|---|---|---|
| committer | Jakub Jelinek <jakub@gcc.gnu.org> | 2012-09-25 14:46:54 +0200 |
| commit | 5717e1f6488ce9b376e1f4a45787687538ec2993 (patch) | |
| tree | b63a6329eba3c58e20da4ed4266ce308aa4285c3 | |
| parent | dadbefd3596a06d06f539e4c0048326a26ac3c75 (diff) | |
| download | gcc-5717e1f6488ce9b376e1f4a45787687538ec2993.zip gcc-5717e1f6488ce9b376e1f4a45787687538ec2993.tar.gz gcc-5717e1f6488ce9b376e1f4a45787687538ec2993.tar.bz2 | |
re PR tree-optimization/54676 (ICE: in set_value_range, at tree-vrp.c:433)
PR tree-optimization/54676
* tree-vrp.c (set_and_canonicalize_value_range): Handle
one bit precision properly.
* gcc.dg/pr54676.c: New test.
From-SVN: r191703
| -rw-r--r-- | gcc/ChangeLog | 4 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/pr54676.c | 23 | ||||
| -rw-r--r-- | gcc/tree-vrp.c | 33 |
4 files changed, 63 insertions, 2 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 44c2ed1..df7ab16 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,9 @@ 2012-09-25 Jakub Jelinek <jakub@redhat.com> + PR tree-optimization/54676 + * tree-vrp.c (set_and_canonicalize_value_range): Handle + one bit precision properly. + PR other/54692 * configure.ac (CFLAGS, CXXFLAGS): Remove -Ofast or -Og properly. diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index d945459..078ebbf 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2012-09-25 Jakub Jelinek <jakub@redhat.com> + + PR tree-optimization/54676 + * gcc.dg/pr54676.c: New test. + 2012-09-25 Richard Guenther <rguenther@suse.de> PR tree-optimization/53663 diff --git a/gcc/testsuite/gcc.dg/pr54676.c b/gcc/testsuite/gcc.dg/pr54676.c new file mode 100644 index 0000000..97032ed --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr54676.c @@ -0,0 +1,23 @@ +/* PR tree-optimization/54676 */ +/* { dg-do compile } */ +/* { dg-options "-O -fno-tree-ccp -fno-tree-copy-prop -fno-tree-fre -ftree-vrp" } */ + +struct S +{ + int s:1; +}; + +struct S bar (void); + +int a; + +void +foo (int x) +{ + struct S s = bar (); + while (!a) + { + int l = 94967295; + a = x || (s.s &= l); + } +} diff --git a/gcc/tree-vrp.c b/gcc/tree-vrp.c index a84c4b9..b728ddd 100644 --- a/gcc/tree-vrp.c +++ b/gcc/tree-vrp.c @@ -501,8 +501,19 @@ set_and_canonicalize_value_range (value_range_t *vr, enum value_range_type t, to adjust them. */ if (tree_int_cst_lt (max, min)) { - tree one = build_int_cst (TREE_TYPE (min), 1); - tree tmp = int_const_binop (PLUS_EXPR, max, one); + tree one, tmp; + + /* For one bit precision if max < min, then the swapped + range covers all values, so for VR_RANGE it is varying and + for VR_ANTI_RANGE empty range, so drop to varying as well. */ + if (TYPE_PRECISION (TREE_TYPE (min)) == 1) + { + set_value_range_to_varying (vr); + return; + } + + one = build_int_cst (TREE_TYPE (min), 1); + tmp = int_const_binop (PLUS_EXPR, max, one); max = int_const_binop (MINUS_EXPR, min, one); min = tmp; @@ -531,6 +542,24 @@ set_and_canonicalize_value_range (value_range_t *vr, enum value_range_type t, set_value_range_to_varying (vr); return; } + else if (TYPE_PRECISION (TREE_TYPE (min)) == 1 + && !TYPE_UNSIGNED (TREE_TYPE (min)) + && (is_min || is_max)) + { + /* For signed 1-bit precision, one is not in-range and + thus adding/subtracting it would result in overflows. */ + if (operand_equal_p (min, max, 0)) + { + min = max = is_min ? vrp_val_max (TREE_TYPE (min)) + : vrp_val_min (TREE_TYPE (min)); + t = VR_RANGE; + } + else + { + set_value_range_to_varying (vr); + return; + } + } else if (is_min /* As a special exception preserve non-null ranges. */ && !(TYPE_UNSIGNED (TREE_TYPE (min)) |