diff options
author | Richard Biener <rguenther@suse.de> | 2019-07-11 07:32:04 +0000 |
---|---|---|
committer | Richard Biener <rguenth@gcc.gnu.org> | 2019-07-11 07:32:04 +0000 |
commit | 3e66e7b0d1efa3f78a5598884e2d5d526894833e (patch) | |
tree | 9c65fdd93d11a334ed47d89dbca153ac6980bcec | |
parent | 639000e2121c2b15f6cdd555ca3f666305b3684d (diff) | |
download | gcc-3e66e7b0d1efa3f78a5598884e2d5d526894833e.zip gcc-3e66e7b0d1efa3f78a5598884e2d5d526894833e.tar.gz gcc-3e66e7b0d1efa3f78a5598884e2d5d526894833e.tar.bz2 |
re PR middle-end/91131 (Bad bitfield coalescing)
2019-07-11 Richard Biener <rguenther@suse.de>
PR middle-end/91131
* gimplify.c (gimplify_compound_literal_expr): Force a temporary
when the object is volatile and we have not cleared it even though
there are no nonzero elements.
* gcc.target/i386/pr91131.c: New testcase.
From-SVN: r273376
-rw-r--r-- | gcc/ChangeLog | 7 | ||||
-rw-r--r-- | gcc/gimplify.c | 2 | ||||
-rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
-rw-r--r-- | gcc/testsuite/gcc.target/i386/pr91131.c | 19 |
4 files changed, 32 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index e5c05e5..ee70694 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2019-07-11 Richard Biener <rguenther@suse.de> + + PR middle-end/91131 + * gimplify.c (gimplify_compound_literal_expr): Force a temporary + when the object is volatile and we have not cleared it even though + there are no nonzero elements. + 2019-07-10 Michael Meissner <meissner@linux.ibm.com> * config/rs6000/predicates.md (cint34_operand): Update diff --git a/gcc/gimplify.c b/gcc/gimplify.c index 239988b..146a86c 100644 --- a/gcc/gimplify.c +++ b/gcc/gimplify.c @@ -5005,7 +5005,7 @@ gimplify_init_constructor (tree *expr_p, gimple_seq *pre_p, gimple_seq *post_p, one field to assign, initialize the target from a temporary. */ if (TREE_THIS_VOLATILE (object) && !TREE_ADDRESSABLE (type) - && num_nonzero_elements > 0 + && (num_nonzero_elements > 0 || !cleared) && vec_safe_length (elts) > 1) { tree temp = create_tmp_var (TYPE_MAIN_VARIANT (type)); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 7172061..efebc72 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2019-07-11 Richard Biener <rguenther@suse.de> + + PR middle-end/91131 + * gcc.target/i386/pr91131.c: New testcase. + 2019-07-10 Martin Sebor <msebor@redhat.com> PR testsuite/91132 diff --git a/gcc/testsuite/gcc.target/i386/pr91131.c b/gcc/testsuite/gcc.target/i386/pr91131.c new file mode 100644 index 0000000..85008ff --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr91131.c @@ -0,0 +1,19 @@ +/* { dg-do compile } */ +/* { dg-options "-O" } */ + +struct Reg_T { + unsigned int a : 3; + unsigned int b : 1; + unsigned int c : 4; +}; + +volatile struct Reg_T Reg_A; + +int +main () +{ + Reg_A = (struct Reg_T){ .a = 0, .b = 0, .c = 0 }; + return 0; +} + +/* { dg-final { scan-assembler-times "mov\[^\r\n\]*Reg_A" 1 } } */ |