aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Botcazou <ebotcazou@libertysurf.fr>2003-11-27 06:20:11 +0100
committerEric Botcazou <ebotcazou@gcc.gnu.org>2003-11-27 05:20:11 +0000
commit316d0b19813c17613fe2dd80f8bba4fd2001eca3 (patch)
tree946c3c7c87e191ddb13beb07b342cb71173d930b
parent27f0f55216eeea3cc81612ecbc235d7704382a77 (diff)
downloadgcc-316d0b19813c17613fe2dd80f8bba4fd2001eca3.zip
gcc-316d0b19813c17613fe2dd80f8bba4fd2001eca3.tar.gz
gcc-316d0b19813c17613fe2dd80f8bba4fd2001eca3.tar.bz2
re PR middle-end/8028 (__builtin_apply() passes wrong arguments)
PR middle-end/8028 PR middle-end/9890 PR middle-end/11151 PR middle-end/12210 PR middle-end/12503 PR middle-end/12692 * builtins.c (expand_builtin_apply): Use virtual_outgoing_args_rtx as the base address to copy the memory arguments to. From-SVN: r73976
-rw-r--r--gcc/ChangeLog11
-rw-r--r--gcc/builtins.c16
-rw-r--r--gcc/testsuite/ChangeLog4
-rw-r--r--gcc/testsuite/gcc.dg/builtin-apply2.c39
4 files changed, 64 insertions, 6 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 7c9c384..f68c34b 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,14 @@
+2003-11-27 Eric Botcazou <ebotcazou@libertysurf.fr>
+
+ PR middle-end/8028
+ PR middle-end/9890
+ PR middle-end/11151
+ PR middle-end/12210
+ PR middle-end/12503
+ PR middle-end/12692
+ * builtins.c (expand_builtin_apply): Use virtual_outgoing_args_rtx
+ as the base address to copy the memory arguments to.
+
2003-11-26 Danny Smith <dannysmith@users.sourceforge.net>
* config/i386/cygming.h (ASM_OUTPUT_DEF_FROM_DECLS): Declare
diff --git a/gcc/builtins.c b/gcc/builtins.c
index 7ff8789..a48c5af 100644
--- a/gcc/builtins.c
+++ b/gcc/builtins.c
@@ -1219,12 +1219,16 @@ expand_builtin_apply (rtx function, rtx arguments, rtx argsize)
#endif
emit_stack_save (SAVE_BLOCK, &old_stack_level, NULL_RTX);
- /* Push a block of memory onto the stack to store the memory arguments.
- Save the address in a register, and copy the memory arguments. ??? I
- haven't figured out how the calling convention macros effect this,
- but it's likely that the source and/or destination addresses in
- the block copy will need updating in machine specific ways. */
- dest = allocate_dynamic_stack_space (argsize, 0, BITS_PER_UNIT);
+ /* Allocate a block of memory onto the stack and copy the memory
+ arguments to the outgoing arguments address. */
+ allocate_dynamic_stack_space (argsize, 0, BITS_PER_UNIT);
+ dest = virtual_outgoing_args_rtx;
+#ifndef STACK_GROWS_DOWNWARD
+ if (GET_CODE (argsize) == CONST_INT)
+ dest = plus_constant (dest, -INTVAL (argsize));
+ else
+ dest = gen_rtx_PLUS (Pmode, dest, negate_rtx (Pmode, argsize));
+#endif
dest = gen_rtx_MEM (BLKmode, dest);
set_mem_align (dest, PARM_BOUNDARY);
src = gen_rtx_MEM (BLKmode, incoming_args);
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 4b8fe13..20faca0 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2003-11-27 Eric Botcazou <ebotcazou@libertysurf.fr>
+
+ * gcc.dg/builtin-apply2.c: New test.
+
2003-11-26 Eric Botcazou <ebotcazou@libertysurf.fr>
* gcc.c-torture/compile/20031023-4.c: Don't XFAIL on SPARC64.
diff --git a/gcc/testsuite/gcc.dg/builtin-apply2.c b/gcc/testsuite/gcc.dg/builtin-apply2.c
new file mode 100644
index 0000000..56b27a1
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/builtin-apply2.c
@@ -0,0 +1,39 @@
+/* PR target/12503 */
+/* Origin: <pierre.nguyen-tuong@asim.lip6.fr> */
+
+/* Verify that __builtin_apply behaves correctly on targets
+ with pre-pushed arguments (e.g. SPARC). */
+
+/* { dg-do run } */
+
+
+#define INTEGER_ARG 5
+
+typedef __SIZE_TYPE__ size_t;
+
+extern void abort(void);
+
+void foo(char *name, double d, double e, double f, int g)
+{
+ if (g != INTEGER_ARG)
+ abort();
+}
+
+void bar(char *name, ...)
+{
+ size_t size;
+ void *arguments;
+
+ size = sizeof(char *) + 3 * sizeof(double) + sizeof(int);
+
+ arguments = __builtin_apply_args();
+
+ __builtin_apply(foo, arguments, size);
+}
+
+int main(void)
+{
+ bar("eeee", 5.444567, 8.90765, 4.567789, INTEGER_ARG);
+
+ return 0;
+}