aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJonathan Wakely <jwakely@redhat.com>2015-07-30 11:00:39 +0100
committerJonathan Wakely <redi@gcc.gnu.org>2015-07-30 11:00:39 +0100
commit2e3f48dc43aae10019e0e56ac0e7323d1e14531a (patch)
tree86a816d8cd0c69972dc16ed8433bed662c8216ba
parent173864e8f143d138c2805c03699d8d58b2c970c8 (diff)
downloadgcc-2e3f48dc43aae10019e0e56ac0e7323d1e14531a.zip
gcc-2e3f48dc43aae10019e0e56ac0e7323d1e14531a.tar.gz
gcc-2e3f48dc43aae10019e0e56ac0e7323d1e14531a.tar.bz2
any (any::operator=(const any&)): Check for self-assignment.
* include/experimental/any (any::operator=(const any&)): Check for self-assignment. * testsuite/experimental/any/assign/self.cc: New. * testsuite/experimental/any/misc/any_cast_neg.cc: Adjust dg-error. From-SVN: r226393
-rw-r--r--libstdc++-v3/ChangeLog7
-rw-r--r--libstdc++-v3/include/experimental/any3
-rw-r--r--libstdc++-v3/testsuite/experimental/any/assign/self.cc41
-rw-r--r--libstdc++-v3/testsuite/experimental/any/misc/any_cast_neg.cc2
4 files changed, 52 insertions, 1 deletions
diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog
index 98758f4..fc4eca9 100644
--- a/libstdc++-v3/ChangeLog
+++ b/libstdc++-v3/ChangeLog
@@ -1,3 +1,10 @@
+2015-07-30 Jonathan Wakely <jwakely@redhat.com>
+
+ * include/experimental/any (any::operator=(const any&)): Check for
+ self-assignment.
+ * testsuite/experimental/any/assign/self.cc: New.
+ * testsuite/experimental/any/misc/any_cast_neg.cc: Adjust dg-error.
+
2015-07-29 Jonathan Wakely <jwakely@redhat.com>
PR libstdc++/66829
diff --git a/libstdc++-v3/include/experimental/any b/libstdc++-v3/include/experimental/any
index 7b5e5ec..fbb70a7 100644
--- a/libstdc++-v3/include/experimental/any
+++ b/libstdc++-v3/include/experimental/any
@@ -175,6 +175,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
/// Copy the state of another object.
any& operator=(const any& __rhs)
{
+ if (this == &__rhs)
+ return *this;
+
if (__rhs.empty())
clear();
else
diff --git a/libstdc++-v3/testsuite/experimental/any/assign/self.cc b/libstdc++-v3/testsuite/experimental/any/assign/self.cc
new file mode 100644
index 0000000..0fb9566
--- /dev/null
+++ b/libstdc++-v3/testsuite/experimental/any/assign/self.cc
@@ -0,0 +1,41 @@
+// Copyright (C) 2015 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-options "-std=gnu++14" }
+
+#include <experimental/any>
+#include <testsuite_hooks.h>
+
+void
+test01()
+{
+ using std::experimental::any;
+
+ any a;
+ a = a;
+ VERIFY( a.empty() );
+
+ a = 1;
+ a = a;
+ VERIFY( !a.empty() );
+}
+
+int
+main()
+{
+ test01();
+}
diff --git a/libstdc++-v3/testsuite/experimental/any/misc/any_cast_neg.cc b/libstdc++-v3/testsuite/experimental/any/misc/any_cast_neg.cc
index 39e3226..b88592a 100644
--- a/libstdc++-v3/testsuite/experimental/any/misc/any_cast_neg.cc
+++ b/libstdc++-v3/testsuite/experimental/any/misc/any_cast_neg.cc
@@ -26,5 +26,5 @@ void test01()
using std::experimental::any_cast;
const any y(1);
- any_cast<int&>(y); // { dg-error "qualifiers" "" { target { *-*-* } } 356 }
+ any_cast<int&>(y); // { dg-error "qualifiers" "" { target { *-*-* } } 359 }
}