diff options
| author | Joseph Myers <jsm@polyomino.org.uk> | 2004-09-30 19:17:54 +0100 |
|---|---|---|
| committer | Joseph Myers <jsm28@gcc.gnu.org> | 2004-09-30 19:17:54 +0100 |
| commit | 254ac10c312a5d9342c9f8514a6c6b94ae405cdb (patch) | |
| tree | 8592fa3e677a407f40204d43f47d95cdc595ac7c | |
| parent | 9c9e97bdb43ba6f8adf64def01d84eed3e0ceee1 (diff) | |
| download | gcc-254ac10c312a5d9342c9f8514a6c6b94ae405cdb.zip gcc-254ac10c312a5d9342c9f8514a6c6b94ae405cdb.tar.gz gcc-254ac10c312a5d9342c9f8514a6c6b94ae405cdb.tar.bz2 | |
re PR c/17730 (Regression in diagnost message "invalid lvalue in unary %<&%>")
PR c/17730
* c-typeck.c (lvalue_or_else): Pass msgid directly to error.
testsuite:
* gcc.dg/pr17730-1.c: New test
From-SVN: r88343
| -rw-r--r-- | gcc/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/c-typeck.c | 6 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/pr17730-1.c | 5 |
4 files changed, 19 insertions, 2 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 29486e3..4cdbe1b 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2004-09-30 Joseph S. Myers <jsm@polyomino.org.uk> + + PR c/17730 + * c-typeck.c (lvalue_or_else): Pass msgid directly to error. + 2004-09-30 Diego Novillo <dnovillo@redhat.com> * tree-ssa-alias.c (collect_points_to_info_r): Move analysis of diff --git a/gcc/c-typeck.c b/gcc/c-typeck.c index d744296..1d79b23 100644 --- a/gcc/c-typeck.c +++ b/gcc/c-typeck.c @@ -2682,7 +2682,9 @@ lvalue_p (tree ref) } /* Return nonzero if REF is an lvalue valid for this language; - otherwise, print an error message and return zero. */ + otherwise, print an error message and return zero. MSGID + is a format string which receives no arguments, but in which + formats such as %< and %> may occur. */ static int lvalue_or_else (tree ref, const char *msgid) @@ -2690,7 +2692,7 @@ lvalue_or_else (tree ref, const char *msgid) int win = lvalue_p (ref); if (! win) - error ("%s", msgid); + error (msgid); return win; } diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 13e29d9..819d422 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2004-09-30 Joseph S. Myers <jsm@polyomino.org.uk> + + PR c/17730 + * gcc.dg/pr17730-1.c: New test + 2004-09-29 Joseph S. Myers <jsm@polyomino.org.uk> PR c/7425 diff --git a/gcc/testsuite/gcc.dg/pr17730-1.c b/gcc/testsuite/gcc.dg/pr17730-1.c new file mode 100644 index 0000000..0fede2f --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr17730-1.c @@ -0,0 +1,5 @@ +/* Test formatting of message for invalid lvalue. Bug 17730. */ +/* { dg-do compile } */ +/* { dg-options "" } */ + +char *p = &'C'; /* { dg-error "error: invalid lvalue in unary '&'" } */ |