aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaolo Carlini <paolo.carlini@oracle.com>2012-09-13 23:04:04 +0000
committerPaolo Carlini <paolo@gcc.gnu.org>2012-09-13 23:04:04 +0000
commit0ccb505dad0cb34b316c3169fe7f4cd74ab02865 (patch)
treee1cf9d9d9344fa47145013bc35c5f60522a5052e
parent03c432bd847bf0088ce4b323f30c29feb6597f0e (diff)
downloadgcc-0ccb505dad0cb34b316c3169fe7f4cd74ab02865.zip
gcc-0ccb505dad0cb34b316c3169fe7f4cd74ab02865.tar.gz
gcc-0ccb505dad0cb34b316c3169fe7f4cd74ab02865.tar.bz2
re PR c++/53210 (warning for data member initialized with itself should be in -Wall)
2012-09-13 Paolo Carlini <paolo.carlini@oracle.com> Manuel López-Ibáñez <manu@gcc.gnu.org> PR c++/53210 * doc/invoke.texi ([Winit-self]): Document as enabled by -Wall in C++. /c-family 2012-09-13 Paolo Carlini <paolo.carlini@oracle.com> Manuel López-Ibáñez <manu@gcc.gnu.org> PR c++/53210 * c.opt ([Winit-self]): Enabled by -Wall in C++. /cp 2012-09-13 Paolo Carlini <paolo.carlini@oracle.com> Manuel López-Ibáñez <manu@gcc.gnu.org> PR c++/53210 * init.c (perform_member_init): Use OPT_Winit_self instead of OPT_Wuninitialized. /testsuite 2012-09-13 Paolo Carlini <paolo.carlini@oracle.com> Manuel López-Ibáñez <manu@gcc.gnu.org> PR c++/53210 * g++.dg/warn/Winit-self.C: New. Co-Authored-By: Manuel López-Ibáñez <manu@gcc.gnu.org> From-SVN: r191284
-rw-r--r--gcc/ChangeLog7
-rw-r--r--gcc/c-family/ChangeLog6
-rw-r--r--gcc/c-family/c.opt2
-rw-r--r--gcc/cp/ChangeLog7
-rw-r--r--gcc/cp/init.c2
-rw-r--r--gcc/doc/invoke.texi2
-rw-r--r--gcc/testsuite/ChangeLog6
-rw-r--r--gcc/testsuite/g++.dg/warn/Winit-self.C8
8 files changed, 38 insertions, 2 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 8653695..e8f1300 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2012-09-13 Paolo Carlini <paolo.carlini@oracle.com>
+ Manuel López-Ibáñez <manu@gcc.gnu.org>
+
+ PR c++/53210
+ * doc/invoke.texi ([Winit-self]): Document as enabled by -Wall
+ in C++.
+
2012-09-13 Eric Botcazou <ebotcazou@adacore.com>
* config/sparc/predicates.md (input_operand): Do not consider TImode
diff --git a/gcc/c-family/ChangeLog b/gcc/c-family/ChangeLog
index 642ff7d..8b3cd2a 100644
--- a/gcc/c-family/ChangeLog
+++ b/gcc/c-family/ChangeLog
@@ -1,3 +1,9 @@
+2012-09-13 Paolo Carlini <paolo.carlini@oracle.com>
+ Manuel López-Ibáñez <manu@gcc.gnu.org>
+
+ PR c++/53210
+ * c.opt ([Winit-self]): Enabled by -Wall in C++.
+
2012-08-23 Arnaud Charlet <charlet@adacore.com>
* c-ada-spec.c (dump_generic_ada_node): Fix handling of name_only
diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt
index 914d110..39d70ad 100644
--- a/gcc/c-family/c.opt
+++ b/gcc/c-family/c.opt
@@ -408,7 +408,7 @@ C C++ Var(warn_ignored_qualifiers) Warning EnabledBy(Wextra)
Warn whenever type qualifiers are ignored.
Winit-self
-C ObjC C++ ObjC++ Var(warn_init_self) Warning
+C ObjC C++ ObjC++ Var(warn_init_self) Warning LangEnabledBy(C++ ObjC++,Wall)
Warn about variables which are initialized to themselves
Wimplicit
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 4a9f5c3..21256df 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,4 +1,11 @@
2012-09-13 Paolo Carlini <paolo.carlini@oracle.com>
+ Manuel López-Ibáñez <manu@gcc.gnu.org>
+
+ PR c++/53210
+ * init.c (perform_member_init): Use OPT_Winit_self instead of
+ OPT_Wuninitialized.
+
+2012-09-13 Paolo Carlini <paolo.carlini@oracle.com>
* typeck.c (build_indirect_ref, build_function_call,
build_function_call_vec, build_binary_op, build_unary_op,
diff --git a/gcc/cp/init.c b/gcc/cp/init.c
index e5abec7..d097443 100644
--- a/gcc/cp/init.c
+++ b/gcc/cp/init.c
@@ -578,7 +578,7 @@ perform_member_init (tree member, tree init)
if (TREE_CODE (val) == COMPONENT_REF && TREE_OPERAND (val, 1) == member
&& TREE_OPERAND (val, 0) == current_class_ref)
warning_at (DECL_SOURCE_LOCATION (current_function_decl),
- OPT_Wuninitialized, "%qD is initialized with itself",
+ OPT_Winit_self, "%qD is initialized with itself",
member);
}
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 0a9226a..61bca25 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -3348,6 +3348,8 @@ int f()
@end group
@end smallexample
+This warning is enabled by @option{-Wall} in C++.
+
@item -Wimplicit-int @r{(C and Objective-C only)}
@opindex Wimplicit-int
@opindex Wno-implicit-int
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 95def4c..54f9cf9 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2012-09-13 Paolo Carlini <paolo.carlini@oracle.com>
+ Manuel López-Ibáñez <manu@gcc.gnu.org>
+
+ PR c++/53210
+ * g++.dg/warn/Wuninitialized-self.C: New.
+
2012-09-13 Jakub Jelinek <jakub@redhat.com>
PR c/54559
diff --git a/gcc/testsuite/g++.dg/warn/Winit-self.C b/gcc/testsuite/g++.dg/warn/Winit-self.C
new file mode 100644
index 0000000..60a7274
--- /dev/null
+++ b/gcc/testsuite/g++.dg/warn/Winit-self.C
@@ -0,0 +1,8 @@
+// PR c++/53210
+// { dg-options "-Wall" }
+
+struct S
+{
+ S(int i) : j(j) { } // { dg-warning "is initialized with itself" }
+ int j;
+};