diff options
| author | Richard Henderson <rth@redhat.com> | 2002-05-29 13:29:21 -0700 |
|---|---|---|
| committer | Richard Henderson <rth@gcc.gnu.org> | 2002-05-29 13:29:21 -0700 |
| commit | 002ff5bc3ea7c58a574c64e4d45d58ff60c6171b (patch) | |
| tree | 0a9bd5d94ab8f9e568b01c40c442821c3c32f51e | |
| parent | edfe859577f8230c1dc6ff13fcbcf5f93bdbcf14 (diff) | |
| download | gcc-002ff5bc3ea7c58a574c64e4d45d58ff60c6171b.zip gcc-002ff5bc3ea7c58a574c64e4d45d58ff60c6171b.tar.gz gcc-002ff5bc3ea7c58a574c64e4d45d58ff60c6171b.tar.bz2 | |
i386.c (ix86_compute_frame_layout): Do add bottom alignment for alloca.
* config/i386/i386.c (ix86_compute_frame_layout): Do add bottom
alignment for alloca.
* gcc.c-torture/execute/alloca-1.c: New.
From-SVN: r54018
| -rw-r--r-- | gcc/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/config/i386/i386.c | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.c-torture/execute/alloca-1.c | 21 |
3 files changed, 29 insertions, 2 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index a761931..14069a7 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,10 @@ 2002-05-29 Richard Henderson <rth@redhat.com> + * config/i386/i386.c (ix86_compute_frame_layout): Do add bottom + alignment for alloca. + +2002-05-29 Richard Henderson <rth@redhat.com> + * config/i386/i386.c (output_pic_addr_const): Lowercase rip. (print_operand_address): Only add rip for symbolic addresses for which we do not have another relocation type. diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 5170c99..877f355 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -4148,8 +4148,9 @@ ix86_compute_frame_layout (frame) else frame->outgoing_arguments_size = 0; - /* Align stack boundary. Only needed if we're calling another function. */ - if (!current_function_is_leaf) + /* Align stack boundary. Only needed if we're calling another function + or using alloca. */ + if (!current_function_is_leaf || current_function_calls_alloca) frame->padding2 = ((offset + preferred_alignment - 1) & -preferred_alignment) - offset; else diff --git a/gcc/testsuite/gcc.c-torture/execute/alloca-1.c b/gcc/testsuite/gcc.c-torture/execute/alloca-1.c new file mode 100644 index 0000000..a8d1384 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/execute/alloca-1.c @@ -0,0 +1,21 @@ +/* Verify that alloca storage is sufficiently aligned. */ +/* ??? May fail if BIGGEST_ALIGNMENT > STACK_BOUNDARY. Which, I guess + can only happen on !STRICT_ALIGNMENT targets. */ + +typedef __SIZE_TYPE__ size_t; + +struct dummy { int x __attribute__((aligned)); }; +#define BIGGEST_ALIGNMENT __alignof__(struct dummy) + +_Bool foo(void) +{ + char *p = __builtin_alloca(32); + return ((size_t)p & (BIGGEST_ALIGNMENT - 1)) == 0; +} + +int main() +{ + if (!foo()) + abort (); + return 0; +} |