Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
(1) use -- in switch commands for safety,
(2) add braces around exprs,
(3) replace abbreviated "info proc" with "info procs",
(4) use -- in regexp commands for safety where the expression is a
variable that could begin with '-'.
|
|
a de-selected dg-do is encountered.
Signed-off-by: Ben Elliston <bje@gnu.org>
|
|
* lib/framework.exp (check_xml): Remove unused proc.
|
|
Signed-off-by: Ben Elliston <bje@gnu.org>
|
|
built compiler, then look in the path.
Signed-off-by: Ben Elliston <bje@gnu.org>
|
|
/bin/which doesn't. Modern systems rely too heavily on symbolic
links (eg. alternatives).
|
|
rlogin. Identified by Frink.
|
|
(1) use -- in switch commands for safety,
(2) remove unreachable return commands after error commands,
(3) replace abbreviated "info proc" with "info procs",
(4) use -- in unset commands for safety where the variable name
is itself a variable.
* lib/dg.exp: Likewise.
* lib/debugger.exp: Likewise.
* lib/framework.exp: Likewise.
* lib/remote.exp: Likewise.
* lib/target.exp: Likewise.
* lib/targetdb.exp: Likewise.
* lib/telnet.exp: Likewise.
* lib/utils.exp: Likewise.
|
|
wrapper. Expect deprecated 'continue -expect' in August 1997.
|
|
behaviour of the UNIX which utility.
* testsuite/runtest.all/utils.test: Test proc which.
|
|
to $output that may be still in $expect_out(buffer) when eof is
matched. Remove arbitrary limitation in the ".+" matching case,
similar to the change to local_exec on 2016-02-17.
|
|
isn't a serious shortcoming, but the comment should be retained.
|
|
* lib/dejagnu.exp: Likewise.
* lib/remote.exp: Likewise.
* lib/utils.exp: Likewise.
|
|
remove FIXME comment about it.
|
|
|
|
|
|
clear errcnt. Instead, pass 0 as argument 2 to perror.
* runtest.exp (runtest): Likewise.
|
|
testsuite still uses diff.
2016-03-15 Ben Elliston <bje@gnu.org>
* lib/utils.exp (diff): Remove proc.
* doc/ref.xml: Update documentation.
* doc/dejagnu.texi: Regenerate.
* NEWS: Update.
|
|
* doc/ref.xml: Update documentation.
* doc/dejagnu.texi: Regenerate.
* NEWS: Update.
|
|
|
|
* lib/dg.exp (dg-test): Likewise.
|
|
|
|
Signed-off-by: Ben Elliston <bje@gnu.org>
|
|
Signed-off-by: Ben Elliston <bje@gnu.org>
|
|
* doc/ref.xml: Update documentation.
* doc/dejagnu.texi: Regenerate.
* NEWS: Update.
This reverts commit 992fbc3a8f03c3cd5e554eea5361f1a531e9e71f.
|
|
* lib/target.exp (default_target_compile): Add D support.
* NEWS: Update.
Signed-off-by: Ben Elliston <bje@gnu.org>
|
|
send_log with a single call to verbose -log. Remove additional
newlines from the log messages.
|
|
|
|
* NEWS: Update.
|
|
* doc/ref.xml: Update documentation.
* doc/dejagnu.texi: Regenerate.
|
|
* doc/ref.xml: Update documentation.
* doc/dejagnu.texi: Regenerate.
|
|
* doc/ref.xml: Update documentation.
* doc/dejagnu.texi: Regenerate.
|
|
* doc/ref.xml: Update documentation.
* doc/dejagnu.texi: Regenerate.
|
|
|
|
verbose when outputting the captured compiler/assembler/linker
diagnostic output as it will already be in the .log file courtesy
of Expect.
|
|
(runtest): Set exit status to 2 if there is any error sourcing
the Tcl scripts.
* lib/framework.exp (unknown): Likewise, set exit status to 2.
* doc/runtest.1: Clarify exit status codes.
* NEWS: Update.
|
|
matched.
|
|
setting exit_status to 1 -- it does.
|
|
(log_and_exit): Remove call to cleanup.
* doc/ref.xml: Remove documentation for cleanup.
* doc/dejagnu.texi: Regenerate.
|
|
* lib/dejagnu.exp (text): Allow angle brackets in test messages.
|
|
<remote>_exec.
Signed-off-by: Ben Elliston <bje@gnu.org>
|
|
|
|
exists case.
Signed-off-by: Ben Elliston <bje@gnu.org>
|
|
Signed-off-by: Ben Elliston <bje@gnu.org>
|
|
output anything. It returns 0 or 1 as its exit code, so "exit `[
-f $file ]`" always expands to "exit " (equivalent to exit 0).
Instead, use test(1) to check for file existence.
Signed-off-by: Ben Elliston <bje@gnu.org>
|
|
|
|
Signed-off-by: Ben Elliston <bje@gnu.org>
|
|
(local_exec, standard_close): Use it.
The code that tries to make sure that a process dies in
lib/remote.exp:remote_close can kill the wrong process due to PID-reuse
races. The GDB buildbots show frequent misterious FAILs that turns out
are caused by this. The problem is this bit here:
exec sh -c "exec > /dev/null 2>&1 && (kill -2 $pgid || kill -2 $pid)
&& sleep 5 && (kill $pgid || kill $pid) && sleep 5 && (kill -9 $pgid || kill -9 $pid) &"
...
catch "wait -i $shell_id"
When this procedure is called to close the GDB process, GDB exits
promptly, but that whole cascade of kills carries on in the background,
thus potentially killing the unfortunate process that manages to be
spawned by one of the next tests and happens to reuse that $pid. [1]
So to fix this, kill that no-longer-needed pipeline as soon as "wait"
returns. There are two places in the DejaGnu with a similar pipeline,
so move that to a shared procedure.
[1] GDB'S testsuite spawns thousands of GDB instances and even more
inferior processes, and of those inferiors, some spawn thousands of
short lived threads in quick succession. Since threads and processes
share the number space in Linux, all that causes PID recycling
frequently. In addition, GDB's testsuite has a parallel test mode that
runs several tests/DejaGnu instances at the same time, further widening
the race window.
Signed-off-by: Ben Elliston <bje@gnu.org>
|
|
instead of appending it.
Some GCC testcases need explicit GCC options to properly run. For
example gcc.target/i386/pr32219-1.c has -fpie specified explicitly:
/* { dg-options "-O2 -fpie" } */
But with multlib, eg:
make check-gcc RUNTESTFLAGS="--target_board='unix{-fpic}'"
-fpic is appended to the command line options, which overrides the command
line options specified by dg-options. multlib flags should be placed at
the beginning of the command line options, not at the end. This patch
updates default_target_compile to prepend multilib_flags, instead of
appending it.
Signed-off-by: Ben Elliston <bje@gnu.org>
|