aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-12-10 * doc/dejagnu.texi (Writing a test case): Add warning aboutJacob Bachmeyer9-29/+122
priority of Expect patterns, complete with example. * testsuite/runtest.all/libs.exp (process_test): Fix bug that caused test results other than "PASS" to be skipped if a "PASS" is further along in the input buffer. Describe problem in manual. (process_test): Ensure that the log file shows each test case run. (process_test): Directly run the test cases instead of using temporary files and "cat". All output is always available in the log file, which is no longer overwritten by other tests. (process_test): Expect END markers from test case scripts. * testsuite/runtest.all/clone_output.test: Emit END markers. * testsuite/runtest.all/config.test: Likewise. * testsuite/runtest.all/remote.test: Likewise. * testsuite/runtest.all/target.test: Likewise. * testsuite/runtest.all/testsuite_file.test: Likewise. * testsuite/runtest.all/utils.test: Likewise. Signed-off-by: Ben Elliston <bje@gnu.org>
2018-12-10 * lib/utils.exp (grep): Use a proper Tcl list for options.Ben Elliston2-5/+9
2018-12-10 * testsuite/runtest.all/utils.test: ${srcdir} -> $srcdir.Ben Elliston2-11/+13
2018-12-10 * lib/utils.exp (getdirs): Use glob -nocomplain rather than globBen Elliston2-31/+30
and catching the "no files matched glob pattern" error message. Catching the error message was the wrong thing to do because the foreach loop then iterates over each word in the error message as if they were matches.
2018-12-10 * testsuite/runtest.all/utils.test (getdirs): Add a test for theBen Elliston2-0/+9
non-existent directory case.
2018-12-10 * runtest.exp: Remove unnecessary quotes and braces aroundBen Elliston2-85/+89
variable expansions.
2018-12-10 * lib/debugger.exp (dumpvars): Remove unnecessary braces.Ben Elliston2-1/+5
2018-12-10 * runtest.exp (setup_target_hook): Use 'ne' and not '!='.Ben Elliston4-7/+16
(iterate_target_variants_two): Likewise. * lib/remote.exp (standard_download): Use 'eq' not '=='. (remote_upload): Likewise. * lib/framework.exp (open_logs): Likewise. (is_remote): Likewise.
2018-12-09Reindent lib/target.exp.Ben Elliston1-61/+61
2018-12-09 * baseboards/basic-sid.exp, baseboards/basic-sim.exp,Ben Elliston24-225/+238
baseboards/i386-sid.exp, baseboards/mt-sid.exp, baseboards/sh-sid.exp, config/adb.exp, config/gdb-comm.exp, config/gdb_stub.exp, config/sim.exp, config/unix.exp, config/vxworks.exp, lib/dejagnu.exp, lib/dg.exp, lib/framework.exp, lib/kermit.exp, lib/libgloss.exp, lib/remote.exp, lib/rsh.exp, lib/target.exp, lib/tip.exp, lib/utils.exp, testsuite/lib/libsup.exp, testsuite/runtest.all/options.exp,: Remove unnecessary braces around variable expansions.
2018-12-09Remove commented out lines in host_execute.Ben Elliston1-3/+0
2018-12-09 * lib/debugger.exp, lib/dg.exp, lib/framework.exp, lib/ftp.exp,Ben Elliston12-113/+120
lib/kermit.exp, lib/libgloss.exp, lib/remote.exp, lib/rlogin.exp, lib/target.exp, lib/tip.exp, lib/utils.exp, runtest.exp: Remove unnecessary quotes and braces around variable expansions.
2018-12-09 * config/gdb-comm.exp: Remove unnecessary quotes.Ben Elliston6-29/+37
* config/gdb_stub.exp: Likewise. * config/vxworks.exp: Likewise. * config/unix.exp: Likewise. * config/sim.exp: Likewise.
2018-12-09 * testsuite/lib/libsup.exp: Remove unnecessary quotes aroundBen Elliston3-7/+13
variable expansions. * testsuite/lib/util-defs.exp: Likewise.
2018-12-09 * baseboards/androideabi.exp: Remove unnecessary quotes and bracesBen Elliston7-18/+28
around variable expansions. * baseboards/basic-sid.exp: Likewise. * baseboards/cris-sim.exp: Likewise. * baseboards/generic-sim.exp: Likewise. * baseboards/mcore-moto-sim.exp: Likewise. * baseboards/multi-sim.exp: Likewise.
2018-12-08 * NEWS: Tweak.Ben Elliston2-6/+8
2018-12-08 * lib/dejagnu.exp (host_execute): Remove unnecessary quotes aroundBen Elliston11-20/+33
variable expansions. * testsuite/runtest.all/clone_output.test: Likewise. * testsuite/runtest.all/target.test: Likewise. * testsuite/runtest.all/stats.exp: Likewise. * testsuite/runtest.all/remote.test: Likewise. * testsuite/runtest.all/config.test: Likewise. * testsuite/runtest.all/default_procs.tcl: Likewise. * testsuite/runtest.all/libs.exp: Likewise. * testsuite/runtest.all/options.exp: Likewise.
2018-12-08 * NEWS: Document 'testsuite' command.Jacob Bachmeyer6-23/+439
* doc/dejagnu.texi (testsuite procedure): Document multiplex entry point and "testsuite file" command. * lib/framework.exp (testsuite): New proc for multiplex commands. (testsuite_file): New proc implementing "testsuite file". * testsuite/runtest.all/testsuite_file.test: New file. * runtest.exp: Expect to find testsuite in ${srcdir}/testsuite, but also search $srcdir itself. (load_lib): Add explicit search for testsuite-local libraries. (load_tool_init): Use $testsuitedir in search. (load_config): Use $testsuitedir instead of $srcdir. (load_tool_target_config): Likewise. Add variable "testsuitedir" for testsuite root directory. Add internal global variables "testbuilddir" and "testdir" for use by "testsuite file". Ensure that $testsuitedir, $testbuilddir, and $objdir also avoid duplicated path delimiters. Add warning if no tests are found and fallback method of searching $srcdir is used. Signed-off-by: Ben Elliston <bje@gnu.org>
2018-12-08Remove commented out code in runtest_start.Ben Elliston1-6/+4
2018-12-08 * testsuite/lib/libsup.exp (start_expect): Brace commands in ifBen Elliston5-7/+15
expressions. * testsuite/lib/util-defs.exp (util_test): Likewise. * testsuite/runtest.all/stats.exp: Likewise. * testsuite/runtest.all/libs.exp: Likewise.
2018-12-08 * testsuite/runtest.all/default_procs.tcl:Ben Elliston2-33/+101
(lib_errpat_test, lib_errregexp_test, lib_err_test): New. (lib_regexp_test): Fix copy-paste-edit error. (lib_pat_test, lib_regexp_test, lib_ret_test, lib_bool_test): Fix handling of errors raised by tested procedure. Also ensure proper quoting of argument lists passed to eval and simplify the logic for producing return values.
2018-12-08 * config/vxworks.exp (${board}_init): Use 'ne' instead of !=.Ben Elliston2-1/+5
2018-12-08 * lib/tip.exp (tip_open): Put braces around if expression.Ben Elliston2-1/+5
2018-12-08 * runtest.exp, lib/utils.exp, lib/targetdb.exp, lib/target.exp,Ben Elliston26-89/+104
lib/remote.exp, lib/framework.exp, lib/dg.exp, config/vxworks.exp, config/sim.exp, config/gdb_stub.exp, config/aarch64-fv8.exp, baseboards/vr4300-sim.exp, baseboards/vr4111-sim.exp, baseboards/vr4100-sim.exp, baseboards/sh-sid.exp, baseboards/mt-sid.exp, baseboards/mips-sim.exp, baseboards/mips-sim-idt64.exp, baseboards/mips-sim-idt32.exp, baseboards/i386-sid.exp, baseboards/arm-sim.exp, baseboards/arm-ice.exp, baseboards/androideabi.exp, testsuite/runtest.all/utils.test, testsuite/runtest.all/target.test: Replace string literal comparisons using == and != with 'eq' and 'ne'.
2018-12-08 * runtest.exp, lib/utils.exp, lib/target.exp, lib/ssh.exp,Ben Elliston25-190/+203
lib/rsh.exp, lib/rlogin.exp, lib/remote.exp, lib/libgloss.exp, lib/framework.exp, lib/dg.exp, lib/dejagnu.exp, config/vxworks.exp, config/unix.exp, config/sim.exp, config/gdb_stub.exp, config/gdb-comm.exp, config/adb.exp, baseboards/multi-sim.exp, baseboards/cris-sim.exp, baseboards/basic-sim.exp, baseboards/basic-sid.exp, baseboards/androideabi.exp, testsuite/runtest.all/load_lib.exp, testsuite/libdejagnu/tunit.exp: Replace empty string comparisons using == and != with 'eq' and 'ne'.
2018-12-07 * testsuite/runtest.all/default_procs.tcl (lib_bool_test): New.Jacob Bachmeyer4-185/+140
(lib_regexp_test): New. (lib_pat_test): Brace "if" conditions. (lib_pat_test): Remove spurious quotes in debugging output. (run_tests): Add support for comments in lists of procedure tests. * testsuite/runtest.all/config.test: Adjust to use run_tests procedure. Fixes issue cited in FIXME comment. * testsuite/runtest.all/utils.test (getdirs tests): Fix these. The old tests had the sense of the return value from lib_pat_test inverted and were failing but reported PASS. (find tests, relative_filename tests, runtest_file_p tests): Adjust to use run_tests procedure. Signed-off-by: Ben Elliston <bje@gnu.org>
2018-12-07 * doc/dejagnu.texi: Add more missing material.Ben Elliston2-0/+46
2018-12-07Fix ChangeLog entry for last commit. It should have been:Jacob Bachmeyer1-7/+3
* testsuite/runtest.all/default_procs.tcl (lib_ret_test): Tidy. (run_tests): Replace implicit "eval" with explicit "eval". Tidy. (verbose): Remove unnecessary quotes. Signed-off-by: Ben Elliston <bje@gnu.org>
2018-12-07 * testsuite/runtest.all/default_procs.tcl: Whitespace clean up.Jacob Bachmeyer2-11/+18
(lib_pat_test): Handle an argument list instead of only a single argument for the procedure under test. (lib_ret_test): Likewise. * testsuite/runtest.all/utils.test: Whitespace clean up. Adjust to pass argument lists for improved lib_pat_test. * testsuite/runtest.all/clone_output.test: Likewise. Signed-off-by: Ben Elliston <bje@gnu.org>
2018-12-06 * doc/dejagnu.texi: Add more missing material.Ben Elliston2-65/+130
2018-12-06 * testsuite/runtest.all/default_procs.tcl: Whitespace clean up.Jacob Bachmeyer4-51/+58
(lib_pat_test): Handle an argument list instead of only a single argument for the procedure under test. (lib_ret_test): Likewise. * testsuite/runtest.all/utils.test: Whitespace clean up. Adjust to pass argument lists for improved lib_pat_test. * testsuite/runtest.all/clone_output.test: Likewise. Signed-off-by: Ben Elliston <bje@gnu.org>
2018-12-06 * lib/remote.exp (standard_load): Fix typo on empty string.Jacob Bachmeyer5-7/+15
* runtest.exp: Adjust expression to follow GNU conventions. * lib/utils.exp (diff): Fix mistake in replacing [string compare] with "eq" instead of "ne". * testsuite/runtest.all/config.test: Likewise. Signed-off-by: Ben Elliston <bje@gnu.org>
2018-12-06 * runtest.exp: Replace [string match] commands involving literalBen Elliston12-31/+44
strings and variables known to not be Tcl glob patterns with eq and ne. * config/unix.exp: Likewise. * lib/debugger.exp: Likewise. * lib/dg.exp: Likewise. * lib/framework.exp: Likewise. * lib/remote.exp: Likewise. * lib/utils.exp: Likewise. * baseboards/androideabi.exp: Likewise. * baseboards/multi-sim.exp: Likewise. * testsuite/lib/util-defs.exp: Likewise. * testsuite/runtest.all/config.test: Likewise.
2018-12-06 * testsuite/runtest.all/utils.test: Add Tcl mode marker for Emacs.Jacob Bachmeyer6-3/+15
* testsuite/runtest.all/target.test: Likewise. * testsuite/runtest.all/remote.test: Likewise. * testsuite/runtest.all/config.test: Likewise. * testsuite/runtest.all/clone_output.test: Likewise. Signed-off-by: Ben Elliston <bje@gnu.org>
2018-12-06Correct whitespace problems.Ben Elliston1-4/+4
2018-12-06 * runtest.exp: Replace '==' with 'eq' for string compares.Ben Elliston9-24/+37
Likewise, replace '!=' with 'ne'. Replace a few instances of [string length $str] == 0 with $str eq "". * config/gdb-comm.exp: Likewise. * lib/dg.exp: Likewise. * lib/framework.exp: Likewise. * lib/libgloss.exp: Likewise. * lib/remote.exp: Likewise. * lib/target.exp: Likewise. * lib/utils.exp: Likewise.
2018-12-06 * runtest.exp: Replace archaic use of [string match] with "eq".Jacob Bachmeyer2-5/+9
Signed-off-by: Ben Elliston <bje@gnu.org>
2018-12-06 * doc/dejagnu.texi (compile Procedure): Remove old node.Ben Elliston2-58/+7
(archive Procedure): Likewise. (ranlib Procedure): Likewise.
2018-12-06 * doc/dejagnu.texi (rsh procedure): Fix node connectivity.Ben Elliston2-1/+5
2018-12-06 * lib/telnet.exp (telnet_open): Remove connectmode global.Ben Elliston3-5/+10
* doc/dejagnu.texi (Procedures For Remote Communication): Remove mention of connectmode.
2018-12-05 * doc/dejagnu.texi (execute_anywhere Procedure): Remove obsoleteBen Elliston2-25/+6
node.
2018-12-05 * doc/dejagnu.texi: Add more missing material.Ben Elliston2-236/+210
2018-12-05 * testsuite/runtest.all/utils.test: Test runtest_file_p.Ben Elliston2-0/+31
2018-12-05 * runtest.exp (load_config): Remove unused globals.Jacob Bachmeyer2-7/+7
(load_generic_config): Likewise. (load_board_description): Likewise. (load_base_board_description): Likewise. Signed-off-by: Ben Elliston <bje@gnu.org>
2018-12-05 * lib/utils.exp (grep): Handle -n.Ben Elliston5-24/+45
* doc/dejagnu.texi (grep procedure): Document it. * testsuite/runtest.all/utils.test: Add a test case. * NEWS: Add an item.
2018-12-05 * testsuite/runtest.all/utils.test: Test diff.Ben Elliston2-1/+42
2018-12-04 * testsuite/runtest.all/utils.test: Test grep.Ben Elliston2-1/+22
2018-12-04 * testsuite/runtest.all/utils.test (which): Fail on the else path,Ben Elliston2-1/+6
don't pass in either case.
2018-12-04Fix some typos.Ben Elliston1-8/+8
2018-12-04 * doc/dejagnu.texi (Libgloss): Improve documentation.Ben Elliston2-52/+88
(Debugging Procedures): Likewise.