From 55cf16e10ce64a8696137d2ce50092b4559561e7 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Wed, 27 Mar 2013 18:49:10 +0000 Subject: Properly check address mode for SIB gas/testsuite/ * gas/i386/addr32.s: Add an SIB test. * gas/i386/addr32.d: Updated. opcodes/ * i386-dis.c (get_sib): Add the sizeflag argument. Properly check address mode. (print_insn): Pass sizeflag to get_sib. --- opcodes/ChangeLog | 6 ++++++ opcodes/i386-dis.c | 8 ++++---- 2 files changed, 10 insertions(+), 4 deletions(-) (limited to 'opcodes') diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index 533c4a3..39c256e 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,9 @@ +2013-03-27 H.J. Lu + + * i386-dis.c (get_sib): Add the sizeflag argument. Properly + check address mode. + (print_insn): Pass sizeflag to get_sib. + 2013-03-27 Alexis Deruelle PR binutils/15068 diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c index 5a77255..eeaf22e 100644 --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -11285,11 +11285,11 @@ get_valid_dis386 (const struct dis386 *dp, disassemble_info *info) } static void -get_sib (disassemble_info *info) +get_sib (disassemble_info *info, int sizeflag) { /* If modrm.mod == 3, operand must be register. */ if (need_modrm - && address_mode != mode_16bit + && ((sizeflag & AFLAG) || address_mode == mode_64bit) && modrm.mod != 3 && modrm.rm == 4) { @@ -11574,7 +11574,7 @@ print_insn (bfd_vma pc, disassemble_info *info) if (dp->name == NULL && dp->op[0].bytemode == FLOATCODE) { - get_sib (info); + get_sib (info, sizeflag); dofloat (sizeflag); } else @@ -11582,7 +11582,7 @@ print_insn (bfd_vma pc, disassemble_info *info) dp = get_valid_dis386 (dp, info); if (dp != NULL && putop (dp->name, sizeflag) == 0) { - get_sib (info); + get_sib (info, sizeflag); for (i = 0; i < MAX_OPERANDS; ++i) { obufp = op_out[i]; -- cgit v1.1