From 3860d2b4b72feeef4cf045c6c9907a0476f46f3d Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Tue, 14 Jun 2016 13:24:37 +0930 Subject: Delete bfd_my_archive macro Many more places use abfd->my_archive rather than bfd_my_archive (abfd), so let's make the code consistently use the first idiom. bfd/ * bfd-in.h (bfd_my_archive): Delete. * bfd-in2.h: Regenerate. binutils/ * ar.c: Expand uses of bfd_my_archive. * size.c: Likewise. ld/ * ldlang.c: Expand uses of bfd_my_archive. * ldmain.c: Likewise. * ldmisc.c: Likewise. * plugin.c: Likewise. --- ld/ChangeLog | 7 +++++++ ld/ldlang.c | 8 ++++---- ld/ldmain.c | 8 ++++---- ld/ldmisc.c | 10 +++++----- ld/plugin.c | 6 +++--- 5 files changed, 23 insertions(+), 16 deletions(-) (limited to 'ld') diff --git a/ld/ChangeLog b/ld/ChangeLog index ac56c8f..4518b46 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,5 +1,12 @@ 2016-06-14 Alan Modra + * ldlang.c: Expand uses of bfd_my_archive. + * ldmain.c: Likewise. + * ldmisc.c: Likewise. + * plugin.c: Likewise. + +2016-06-14 Alan Modra + PR ld/20241 * ldmain.c (add_archive_element): Just print file name of file within thin archives. diff --git a/ld/ldlang.c b/ld/ldlang.c index 1cbba39..f29651a 100644 --- a/ld/ldlang.c +++ b/ld/ldlang.c @@ -2499,9 +2499,9 @@ wild_sort (lang_wild_statement_type *wild, archive. */ if (file->the_bfd != NULL - && bfd_my_archive (file->the_bfd) != NULL) + && file->the_bfd->my_archive != NULL) { - fn = bfd_get_filename (bfd_my_archive (file->the_bfd)); + fn = bfd_get_filename (file->the_bfd->my_archive); fa = TRUE; } else @@ -2510,9 +2510,9 @@ wild_sort (lang_wild_statement_type *wild, fa = FALSE; } - if (bfd_my_archive (ls->section->owner) != NULL) + if (ls->section->owner->my_archive != NULL) { - ln = bfd_get_filename (bfd_my_archive (ls->section->owner)); + ln = bfd_get_filename (ls->section->owner->my_archive); la = TRUE; } else diff --git a/ld/ldmain.c b/ld/ldmain.c index 3c5065f..406833b 100644 --- a/ld/ldmain.c +++ b/ld/ldmain.c @@ -865,17 +865,17 @@ add_archive_element (struct bfd_link_info *info, header_printed = TRUE; } - if (bfd_my_archive (abfd) == NULL - || bfd_is_thin_archive (bfd_my_archive (abfd))) + if (abfd->my_archive == NULL + || bfd_is_thin_archive (abfd->my_archive)) { minfo ("%s", bfd_get_filename (abfd)); len = strlen (bfd_get_filename (abfd)); } else { - minfo ("%s(%s)", bfd_get_filename (bfd_my_archive (abfd)), + minfo ("%s(%s)", bfd_get_filename (abfd->my_archive), bfd_get_filename (abfd)); - len = (strlen (bfd_get_filename (bfd_my_archive (abfd))) + len = (strlen (bfd_get_filename (abfd->my_archive)) + strlen (bfd_get_filename (abfd)) + 2); } diff --git a/ld/ldmisc.c b/ld/ldmisc.c index 321db9a..5efff74 100644 --- a/ld/ldmisc.c +++ b/ld/ldmisc.c @@ -231,13 +231,13 @@ vfinfo (FILE *fp, const char *fmt, va_list arg, bfd_boolean is_warning) lang_input_statement_type *i; i = va_arg (arg, lang_input_statement_type *); - if (bfd_my_archive (i->the_bfd) != NULL - && !bfd_is_thin_archive (bfd_my_archive (i->the_bfd))) + if (i->the_bfd->my_archive != NULL + && !bfd_is_thin_archive (i->the_bfd->my_archive)) fprintf (fp, "(%s)", - bfd_get_filename (bfd_my_archive (i->the_bfd))); + bfd_get_filename (i->the_bfd->my_archive)); fprintf (fp, "%s", i->local_sym_name); - if ((bfd_my_archive (i->the_bfd) == NULL - || bfd_is_thin_archive (bfd_my_archive (i->the_bfd))) + if ((i->the_bfd->my_archive == NULL + || bfd_is_thin_archive (i->the_bfd->my_archive)) && filename_cmp (i->local_sym_name, i->filename) != 0) fprintf (fp, " (%s)", i->filename); } diff --git a/ld/plugin.c b/ld/plugin.c index c347cfa..ebde25f 100644 --- a/ld/plugin.c +++ b/ld/plugin.c @@ -1089,9 +1089,9 @@ plugin_object_p (bfd *ibfd) return NULL; } - inarchive = (bfd_my_archive (ibfd) != NULL - && !bfd_is_thin_archive (bfd_my_archive (ibfd))); - name = inarchive ? bfd_my_archive (ibfd)->filename : ibfd->filename; + inarchive = (ibfd->my_archive != NULL + && !bfd_is_thin_archive (ibfd->my_archive)); + name = inarchive ? ibfd->my_archive->filename : ibfd->filename; fd = open (name, O_RDONLY | O_BINARY); if (fd < 0) -- cgit v1.1