From f8de51293246a17166da9a2744c1eb5ab956d67b Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Mon, 13 Jan 2014 14:56:29 +0000 Subject: tfile: Don't infer the PC from the tracepoint if the PC is a pseudo-register. This PC guessing can't work when the PC is a pseudo-register. Pseudo-register values don't end up stored in the regcache, they're always recomputed. And, it's actually wrong to try to write a pseudo-register with regcache_raw_supply. Skip it and add a comment. gdb/ 2014-01-13 Pedro Alves * tracepoint.c (tfile_fetch_registers): Don't infer the PC from the tracepoint if the PC is a pseudo-register. --- gdb/tracepoint.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'gdb/tracepoint.c') diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c index 582c284..4b47282 100644 --- a/gdb/tracepoint.c +++ b/gdb/tracepoint.c @@ -5060,7 +5060,17 @@ tfile_fetch_registers (struct target_ops *ops, /* We can often usefully guess that the PC is going to be the same as the address of the tracepoint. */ pc_regno = gdbarch_pc_regnum (gdbarch); - if (pc_regno >= 0 && (regno == -1 || regno == pc_regno)) + + /* XXX This guessing code below only works if the PC register isn't + a pseudo-register. The value of a pseudo-register isn't stored + in the (non-readonly) regcache -- instead it's recomputed + (probably from some other cached raw register) whenever the + register is read. This guesswork should probably move to some + higher layer. */ + if (pc_regno < 0 || pc_regno >= gdbarch_num_regs (gdbarch)) + return; + + if (regno == -1 || regno == pc_regno) { struct tracepoint *tp = get_tracepoint (tracepoint_number); -- cgit v1.1