From 6533cbeeb831224e2d2dd2a7bea54b22b798fa39 Mon Sep 17 00:00:00 2001 From: Johnson Sun Date: Fri, 21 Oct 2022 01:49:18 +0800 Subject: Fix deletion of FinishBreakpoints Currently, FinishBreakpoints are set at the return address of a frame based on the `finish' command, and are meant to be temporary breakpoints. However, they are not being cleaned up after use, as reported in PR python/18655. This was happening because the disposition of the breakpoint was not being set correctly. This commit fixes this issue by correctly setting the disposition in the post-stop hook of the breakpoint. It also adds a test to ensure this feature isn't regressed in the future. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=18655 --- .../gdb.python/py-finish-breakpoint-deletion.c | 31 ++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 gdb/testsuite/gdb.python/py-finish-breakpoint-deletion.c (limited to 'gdb/testsuite/gdb.python/py-finish-breakpoint-deletion.c') diff --git a/gdb/testsuite/gdb.python/py-finish-breakpoint-deletion.c b/gdb/testsuite/gdb.python/py-finish-breakpoint-deletion.c new file mode 100644 index 0000000..b6e7151 --- /dev/null +++ b/gdb/testsuite/gdb.python/py-finish-breakpoint-deletion.c @@ -0,0 +1,31 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2022 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +static int +subroutine (int a) +{ + return a; +} + +int +main (void) +{ + int i; + for (i = 0; i < 5; i++) + subroutine (i); + return 0; +} -- cgit v1.1