From 5c328c057e963faacc50796c650a5feb06762c67 Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Sun, 23 Feb 2014 12:24:08 +0800 Subject: Remove TARGET_XFER_STATUS_ERROR_P This patch removes macro TARGET_XFER_STATUS_ERROR_P, as Pedro pointed out during patches review that TARGET_XFER_STATUS_ERROR_P tends to be unnecessary. gdb: 2014-02-24 Yao Qi * target.h (TARGET_XFER_STATUS_ERROR_P): Remove. * corefile.c (read_memory): Adjusted. * target.c (target_write_with_progress): Adjusted. --- gdb/target.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'gdb/target.c') diff --git a/gdb/target.c b/gdb/target.c index 0f3bd30..60a11dd 100644 --- a/gdb/target.c +++ b/gdb/target.c @@ -2002,12 +2002,9 @@ target_write_with_progress (struct target_ops *ops, offset + xfered, len - xfered, &xfered_len); - if (status == TARGET_XFER_EOF) - return xfered; - if (TARGET_XFER_STATUS_ERROR_P (status)) - return -1; + if (status != TARGET_XFER_OK) + return status == TARGET_XFER_EOF ? xfered : -1; - gdb_assert (status == TARGET_XFER_OK); if (progress) (*progress) (xfered_len, baton); -- cgit v1.1