From 62982abdee45cb20a7cfadb2b1bcc358655d4ad3 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Tue, 19 May 2020 12:18:04 -0400 Subject: gdb: allocate symfile_segment_data with new - Allocate this structure with new instead of XNEW, use a unique pointer to manage its lifetime. - Change a few functions to return a unique pointer instead of a plain pointer. - Change free_symfile_segment_data to be symfile_segment_data's destructor. gdb/ChangeLog: * symfile.h (struct symfile_segment_data): Initialize fields. <~symfile_segment_data>: Add. (symfile_segment_data_up): New. (struct sym_fns) : Return a symfile_segment_data_up. (default_symfile_segments): Return a symfile_segment_data_up. (free_symfile_segment_data): Remove. (get_symfile_segment_data): Return a symfile_segment_data_up. * symfile.c (default_symfile_segments): Likewise. (get_symfile_segment_data): Likewise. (free_symfile_segment_data): Remove. (symfile_find_segment_sections): Update. * elfread.c (elf_symfile_segments): Return a symfile_segment_data_up. * remote.c (remote_target::get_offsets): Update. * solib-target.c (solib_target_relocate_section_addresses): Update. * symfile-debug.c (debug_sym_segments): Return a symfile_segment_data_up. --- gdb/symfile-debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gdb/symfile-debug.c') diff --git a/gdb/symfile-debug.c b/gdb/symfile-debug.c index 203609c..bd806fd 100644 --- a/gdb/symfile-debug.c +++ b/gdb/symfile-debug.c @@ -475,7 +475,7 @@ debug_sym_offsets (struct objfile *objfile, debug_data->real_sf->sym_offsets (objfile, info); } -static struct symfile_segment_data * +static symfile_segment_data_up debug_sym_segments (bfd *abfd) { /* This API function is annoying, it doesn't take a "this" pointer. -- cgit v1.1