From eae8aa302e9a76565bca1cf381e76125e1d9ff89 Mon Sep 17 00:00:00 2001 From: Fred Fish Date: Sat, 6 Apr 1996 10:19:19 +0000 Subject: * symfile.c (INLINE_ADD_PSYMBOL): Remove ifdef. (add_psymbol_to_list): Add an arg for passing CORE_ADDR values and use it, rather than calling add_psymbol_addr_to_list. (add_psymbol_addr_to_list): Delete. (add_psymbol_to_list): Make psymbol static to avoid random data in gaps due to alignment of structure members. * symfile.h (INLINE_ADD_PSYMBOL, ADD_PSYMBOL_TO_LIST, ADD_PSYMBOL_ADDR_TO_LIST): Remove. Real world tests show no performance improvements by inlining via complicated macros and they just make gdb larger and harder to maintain. * dwarfread.c (add_enum_psymbol): Replace ADD_PSYMBOL_TO_LIST and/or ADD_PSYMBOL_ADDR_TO_LIST macro(s) with call to add_psymbol_to_list with appropriate long or CORE_ADDR args. (add_partial_symbol): Ditto. * partial-stab.h: Ditto. * os9kread.c (read_os9k_psymtab): Ditto * mdebugread.c (parse_partial_symbols): Ditto. (handle_psymbol_enumerators): Ditto. (demangle.h): Include. * hpread.c (hpread_build_psymtabs): Ditto. (hpread_build_psymtabs): Ditto. (demangle.h): Include --- gdb/os9kread.c | 68 +++++++++++++++++++++++++++++----------------------------- 1 file changed, 34 insertions(+), 34 deletions(-) (limited to 'gdb/os9kread.c') diff --git a/gdb/os9kread.c b/gdb/os9kread.c index edef8bc..f80cb1b 100644 --- a/gdb/os9kread.c +++ b/gdb/os9kread.c @@ -737,35 +737,35 @@ read_os9k_psymtab (section_offsets, objfile, text_addr, text_size) } case 'v': - ADD_PSYMBOL_ADDR_TO_LIST (namestring, p - namestring, - VAR_NAMESPACE, LOC_STATIC, - objfile->static_psymbols, - CUR_SYMBOL_VALUE, - psymtab_language, objfile); + add_psymbol_to_list (namestring, p - namestring, + VAR_NAMESPACE, LOC_STATIC, + &objfile->static_psymbols, + 0, CUR_SYMBOL_VALUE, + psymtab_language, objfile); continue; case 'V': - ADD_PSYMBOL_ADDR_TO_LIST (namestring, p - namestring, - VAR_NAMESPACE, LOC_STATIC, - objfile->global_psymbols, - CUR_SYMBOL_VALUE, - psymtab_language, objfile); + add_psymbol_to_list (namestring, p - namestring, + VAR_NAMESPACE, LOC_STATIC, + &objfile->global_psymbols, + 0, CUR_SYMBOL_VALUE, + psymtab_language, objfile); continue; case 'T': if (p != namestring) /* a name is there, not just :T... */ { - ADD_PSYMBOL_TO_LIST (namestring, p - namestring, + add_psymbol_to_list (namestring, p - namestring, STRUCT_NAMESPACE, LOC_TYPEDEF, - objfile->static_psymbols, - CUR_SYMBOL_VALUE, + &objfile->static_psymbols, + CUR_SYMBOL_VALUE, 0, psymtab_language, objfile); if (p[2] == 't') { /* Also a typedef with the same name. */ - ADD_PSYMBOL_TO_LIST (namestring, p - namestring, + add_psymbol_to_list (namestring, p - namestring, VAR_NAMESPACE, LOC_TYPEDEF, - objfile->static_psymbols, - CUR_SYMBOL_VALUE, psymtab_language, + &objfile->static_psymbols, + CUR_SYMBOL_VALUE, 0, psymtab_language, objfile); p += 1; } @@ -777,10 +777,10 @@ read_os9k_psymtab (section_offsets, objfile, text_addr, text_size) else if (psymtab_language == language_cplus) { /* Also a typedef with the same name. */ - ADD_PSYMBOL_TO_LIST (namestring, p - namestring, + add_psymbol_to_list (namestring, p - namestring, VAR_NAMESPACE, LOC_TYPEDEF, - objfile->static_psymbols, - CUR_SYMBOL_VALUE, psymtab_language, + &objfile->static_psymbols, + CUR_SYMBOL_VALUE, 0, psymtab_language, objfile); } } @@ -788,10 +788,10 @@ read_os9k_psymtab (section_offsets, objfile, text_addr, text_size) case 't': if (p != namestring) /* a name is there, not just :T... */ { - ADD_PSYMBOL_TO_LIST (namestring, p - namestring, + add_psymbol_to_list (namestring, p - namestring, VAR_NAMESPACE, LOC_TYPEDEF, - objfile->static_psymbols, - CUR_SYMBOL_VALUE, + &objfile->static_psymbols, + CUR_SYMBOL_VALUE, 0, psymtab_language, objfile); } check_enum: @@ -841,10 +841,10 @@ read_os9k_psymtab (section_offsets, objfile, text_addr, text_size) ; /* Note that the value doesn't matter for enum constants in psymtabs, just in symtabs. */ - ADD_PSYMBOL_TO_LIST (p, q - p, + add_psymbol_to_list (p, q - p, VAR_NAMESPACE, LOC_CONST, - objfile->static_psymbols, 0, - psymtab_language, objfile); + &objfile->static_psymbols, 0, + 0, psymtab_language, objfile); /* Point past the name. */ p = q; /* Skip over the value. */ @@ -858,10 +858,10 @@ read_os9k_psymtab (section_offsets, objfile, text_addr, text_size) continue; case 'c': /* Constant, e.g. from "const" in Pascal. */ - ADD_PSYMBOL_TO_LIST (namestring, p - namestring, + add_psymbol_to_list (namestring, p - namestring, VAR_NAMESPACE, LOC_CONST, - objfile->static_psymbols, CUR_SYMBOL_VALUE, - psymtab_language, objfile); + &objfile->static_psymbols, CUR_SYMBOL_VALUE, + 0, psymtab_language, objfile); continue; case 'f': @@ -869,10 +869,10 @@ read_os9k_psymtab (section_offsets, objfile, text_addr, text_size) if (pst && pst->textlow == 0) pst->textlow = CUR_SYMBOL_VALUE; - ADD_PSYMBOL_TO_LIST (namestring, p - namestring, + add_psymbol_to_list (namestring, p - namestring, VAR_NAMESPACE, LOC_BLOCK, - objfile->static_psymbols, CUR_SYMBOL_VALUE, - psymtab_language, objfile); + &objfile->static_psymbols, CUR_SYMBOL_VALUE, + 0, psymtab_language, objfile); continue; case 'F': @@ -880,10 +880,10 @@ read_os9k_psymtab (section_offsets, objfile, text_addr, text_size) if (pst && pst->textlow == 0) pst->textlow = CUR_SYMBOL_VALUE; - ADD_PSYMBOL_TO_LIST (namestring, p - namestring, + add_psymbol_to_list (namestring, p - namestring, VAR_NAMESPACE, LOC_BLOCK, - objfile->global_psymbols, CUR_SYMBOL_VALUE, - psymtab_language, objfile); + &objfile->global_psymbols, CUR_SYMBOL_VALUE, + 0, psymtab_language, objfile); continue; case 'p': -- cgit v1.1