From fec4e896d6834bc6d23b9d666910dce43f2a2184 Mon Sep 17 00:00:00 2001 From: Christian Biesinger Date: Wed, 9 Oct 2019 20:08:13 -0500 Subject: Create xml-builtin.h to declare xml_builtins xml-builtin.c only has character arrays and no dependencies, so this creates a simple header file for that purpose so that gdbserver can include that instead of re-declaring xml_builtin. Despite the name, feature_to_c.sh is already specific to xml_builtins (it hardcodes the variable name), so making it always output the include for xml-builtin.h seems fine. gdb/ChangeLog: 2019-10-16 Christian Biesinger * Makefile.in: Add xml-builtin.h. * features/feature_to_c.sh: Add an include for xml-builtin.h to ensure that the compiler checks that the types match. * xml-builtin.h: New file. * xml-support.c (fetch_xml_builtin): Add missing const. * xml-support.h: Remove declaration of xml_builtins. gdb/gdbserver/ChangeLog: 2019-10-16 Christian Biesinger * server.c: Include xml-builtin.h. (get_xml_features): Don't declare xml_builtins here. Change-Id: I806ef0851c43ead90b545a11794e41f5e5178436 --- gdb/features/feature_to_c.sh | 2 ++ 1 file changed, 2 insertions(+) (limited to 'gdb/features') diff --git a/gdb/features/feature_to_c.sh b/gdb/features/feature_to_c.sh index 2e7e0c7..ae83774 100755 --- a/gdb/features/feature_to_c.sh +++ b/gdb/features/feature_to_c.sh @@ -32,6 +32,8 @@ if test -e "$output"; then exit 1 fi +echo '#include "xml-builtin.h"' >> $output + for input; do arrayname=xml_feature_`echo $input | sed 's,.*/,,; s/[-.]/_/g'` -- cgit v1.1