From a8142ee195063e8c7202429e80ee58185c34b3fc Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Tue, 5 Dec 2017 16:30:25 -0500 Subject: Make tdesc_reg string fields std::string Make the name, group and type fields of tdesc_reg std::strings. This way, we don't have to manually free them in ~tdesc_reg. Doing so results in a small change in the generated tdesc. Instead of passing an empty string for the group parameter of tdesc_create_reg, the two modified tdesc now pass NULL. The end result should be the same. gdb/ChangeLog: * target-descriptions.c (struct tdesc_reg) : Change type of name_ parameter, adjust to std::string change. : Change type to std::string. <~tdesc_reg>: Replace with default implementation. : Adjust. (tdesc_find_register_early): Adjust. (tdesc_register_name): Adjust. (tdesc_register_type): Adjust. (tdesc_register_in_reggroup_p): Adjust. (class print_c_tdesc) : Adjust. (class print_c_feature) : Adjust. --- gdb/features/arc-arcompact.c | 2 +- gdb/features/arc-v2.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'gdb/features') diff --git a/gdb/features/arc-arcompact.c b/gdb/features/arc-arcompact.c index ea84a40..fd11e31 100644 --- a/gdb/features/arc-arcompact.c +++ b/gdb/features/arc-arcompact.c @@ -48,7 +48,7 @@ initialize_tdesc_arc_arcompact (void) tdesc_create_reg (feature, "ilink2", 30, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "blink", 31, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "lp_count", 32, 1, NULL, 32, "uint32"); - tdesc_create_reg (feature, "pcl", 33, 1, "", 32, "code_ptr"); + tdesc_create_reg (feature, "pcl", 33, 1, NULL, 32, "code_ptr"); feature = tdesc_create_feature (result, "org.gnu.gdb.arc.aux-minimal"); struct tdesc_type *field_type; diff --git a/gdb/features/arc-v2.c b/gdb/features/arc-v2.c index 1eefc24..6eeefdb 100644 --- a/gdb/features/arc-v2.c +++ b/gdb/features/arc-v2.c @@ -45,10 +45,10 @@ initialize_tdesc_arc_v2 (void) tdesc_create_reg (feature, "fp", 27, 1, NULL, 32, "data_ptr"); tdesc_create_reg (feature, "sp", 28, 1, NULL, 32, "data_ptr"); tdesc_create_reg (feature, "ilink", 29, 1, NULL, 32, "code_ptr"); - tdesc_create_reg (feature, "r30", 30, 1, "", 32, "int"); + tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "int"); tdesc_create_reg (feature, "blink", 31, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "lp_count", 32, 1, NULL, 32, "uint32"); - tdesc_create_reg (feature, "pcl", 33, 1, "", 32, "code_ptr"); + tdesc_create_reg (feature, "pcl", 33, 1, NULL, 32, "code_ptr"); feature = tdesc_create_feature (result, "org.gnu.gdb.arc.aux-minimal"); struct tdesc_type *field_type; -- cgit v1.1