From 8fc48b79618af335d6cea1d1d149668340298b81 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Fri, 8 Jan 2021 12:20:12 -0700 Subject: Pass void_context_p to parse_expression An earlier patch pointed out that nothing in GDB sets void_context_p when parsing an expression. This patch fixes this omission. "print" and "call" differ in that the former will print a value that has void type, while the latter will not. AdaCore has had a patch for a long time that uses this distinction to help with overload resolution. In particular, in a "call" context, a procedure will be chosen, while in a "print" context, a zero-argument function will be chosen instead. Regression tested on x86-64 Fedora 32. gdb/ChangeLog 2021-01-08 Tom Tromey * parse.c (parse_expression): Add void_context_p parameter. Use parse_exp_in_context. * printcmd.c (print_command_1): Change voidprint to bool. Pass to parse_expression. (print_command, call_command): Update. * expression.h (parse_expression): Add void_context_p parameter. gdb/testsuite/ChangeLog 2021-01-08 Tom Tromey * gdb.ada/voidctx/pck.adb: New file. * gdb.ada/voidctx/pck.ads: New file. * gdb.ada/voidctx/voidctx.adb: New file. * gdb.ada/voidctx.exp: New file. --- gdb/expression.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'gdb/expression.h') diff --git a/gdb/expression.h b/gdb/expression.h index 8c0bcc9..e70169e 100644 --- a/gdb/expression.h +++ b/gdb/expression.h @@ -142,7 +142,8 @@ typedef std::unique_ptr expression_up; class innermost_block_tracker; extern expression_up parse_expression (const char *, - innermost_block_tracker * = nullptr); + innermost_block_tracker * = nullptr, + bool void_context_p = false); extern expression_up parse_expression_with_language (const char *string, enum language lang); -- cgit v1.1