From 25e3c82c0e927398e759e2d5e35623012b8683f7 Mon Sep 17 00:00:00 2001 From: Sergio Durigan Junior Date: Fri, 9 Feb 2018 18:54:41 -0500 Subject: Make gdbserver work with filename-only binaries Simon mentioned on IRC that, after the startup-with-shell feature has been implemented on gdbserver, it is not possible to specify a filename-only binary, like: $ gdbserver :1234 a.out /bin/bash: line 0: exec: a.out: not found During startup program exited with code 127. Exiting This happens on systems where the current directory "." is not listed in the PATH environment variable. Although including "." in the PATH variable is a possible workaround, this can be considered a regression because before startup-with-shell it was possible to use only the filename (due to reason that gdbserver used "exec*" directly). The idea of the patch is to verify if the program path provided by the user (or by the remote protocol) contains a directory separator character. If it doesn't, it means we're dealing with a filename-only binary, so we call "gdb_abspath" to properly expand it and transform it into a full path. Otherwise, we leave the program path untouched. This mimicks the behaviour seen on GDB (look at "openp" and "attach_inferior", for example). I am also submitting a testcase which exercises the scenario described above. This test requires gdbserver to be executed in a different CWD than the original, so I also created a helper function, "with_cwd" (on testsuite/lib/gdb.exp), which takes care of cd'ing into and out of the specified dir. Built and regtested on BuildBot, without regressions. gdb/ChangeLog: 2018-02-28 Sergio Durigan Junior Simon Marchi * common/common-utils.c: Include "sys/stat.h". (is_regular_file): Move here from "source.c"; change return type to "bool". * common/common-utils.h (is_regular_file): New prototype. * common/pathstuff.c (contains_dir_separator): New function. * common/pathstuff.h (contains_dir_separator): New prototype. * source.c: Don't include "sys/stat.h". (is_regular_file): Move to "common/common-utils.c". gdb/gdbserver/ChangeLog: 2018-02-28 Sergio Durigan Junior * server.c: Include "filenames.h" and "pathstuff.h". (program_name): Delete variable. (program_path): New anonymous class. (get_exec_wrapper): Use "program_path" instead of "program_name". (handle_v_run): Likewise. (captured_main): Likewise. (process_serial_event): Likewise. gdb/testsuite/ChangeLog: 2018-02-28 Sergio Durigan Junior * gdb.server/abspath.exp: New file. * lib/gdb.exp (with_cwd): New procedure. --- gdb/common/pathstuff.h | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'gdb/common/pathstuff.h') diff --git a/gdb/common/pathstuff.h b/gdb/common/pathstuff.h index 3cb02c8..9f26127 100644 --- a/gdb/common/pathstuff.h +++ b/gdb/common/pathstuff.h @@ -46,4 +46,8 @@ extern gdb::unique_xmalloc_ptr extern gdb::unique_xmalloc_ptr gdb_abspath (const char *path); +/* Return whether PATH contains a directory separator character. */ + +extern bool contains_dir_separator (const char *path); + #endif /* PATHSTUFF_H */ -- cgit v1.1