From cc6fd584ed920b14d57703bb62c9ed773cea3732 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Fri, 20 Nov 2020 10:31:07 +0000 Subject: Fix SHF_GNU_RETAIN testsuite fallout binutils/ChangeLog: * testsuite/binutils-all/readelf-maskos-1a.d: Fix test for unrecognized bit set in SHF_MASKOS range. * testsuite/binutils-all/readelf-maskos-1b.d: Likewise. * testsuite/binutils-all/readelf-maskos-unknown.s: New test. ld/ChangeLog: * testsuite/ld-elf/retain3.s: Move symbolic reference into writeable .data section from read-only .text section. * testsuite/ld-elf/retain5.d: Don't pass --print-gc-sections for test that doesn't require it. * testsuite/ld-elf/retain6a.d: Adjust test. * testsuite/ld-elf/retain6main.s: Move symbolic reference into writeable .data section from read-only .text section. --- binutils/ChangeLog | 7 +++++++ binutils/testsuite/binutils-all/readelf-maskos-1a.d | 10 +++++----- binutils/testsuite/binutils-all/readelf-maskos-1b.d | 12 ++++++------ binutils/testsuite/binutils-all/readelf-maskos-unknown.s | 11 +++++++++++ 4 files changed, 29 insertions(+), 11 deletions(-) create mode 100644 binutils/testsuite/binutils-all/readelf-maskos-unknown.s (limited to 'binutils') diff --git a/binutils/ChangeLog b/binutils/ChangeLog index e8bcd97..4acc0d4 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,10 @@ +2020-11-20 Jozef Lawrynowicz + + * testsuite/binutils-all/readelf-maskos-1a.d: Fix test for unrecognized + bit set in SHF_MASKOS range. + * testsuite/binutils-all/readelf-maskos-1b.d: Likewise. + * testsuite/binutils-all/readelf-maskos-unknown.s: New test. + 2020-11-18 Jozef Lawrynowicz * NEWS: Announce SHF_GNU_RETAIN support. diff --git a/binutils/testsuite/binutils-all/readelf-maskos-1a.d b/binutils/testsuite/binutils-all/readelf-maskos-1a.d index 7b27358..cb18b3b 100644 --- a/binutils/testsuite/binutils-all/readelf-maskos-1a.d +++ b/binutils/testsuite/binutils-all/readelf-maskos-1a.d @@ -1,10 +1,10 @@ #name: Unknown SHF_MASKOS value in section -#source: readelf-maskos.s -#notarget: [supports_gnu_osabi] msp430-*-elf visium-*-elf -#xfail: arm-*-elf +#source: readelf-maskos-unknown.s +#notarget: mips-*-* hppa-*-* score-*-* msp430-*-elf visium-*-elf #readelf: -S --wide -# PR26722 for the arm-*-elf XFAIL +# Only run this test for targets that are not ELFOSABI_STANDALONE, and do not +# set SHF_MASKOS bit 0x8000000. #... - \[[ 0-9]+\] .data.retain_var.*WAo.* + \[[ 0-9]+\] .data.var.*WAo.* #pass diff --git a/binutils/testsuite/binutils-all/readelf-maskos-1b.d b/binutils/testsuite/binutils-all/readelf-maskos-1b.d index 2cbb58a..5c363f6 100644 --- a/binutils/testsuite/binutils-all/readelf-maskos-1b.d +++ b/binutils/testsuite/binutils-all/readelf-maskos-1b.d @@ -1,12 +1,12 @@ #name: -t (section details) for unknown SHF_MASKOS value in section -#source: readelf-maskos.s -#notarget: [supports_gnu_osabi] msp430-*-elf visium-*-elf -#xfail: arm-*-elf +#source: readelf-maskos-unknown.s +#notarget: mips-*-* hppa-*-* score-*-* msp430-*-elf visium-*-elf #readelf: -S -t --wide -# PR26722 for the arm-*-elf XFAIL +# Only run this test for targets that are not ELFOSABI_STANDALONE, and do not +# set SHF_MASKOS bit 0x8000000. #... - \[[ 0-9]+\] .data.retain_var + \[[ 0-9]+\] .data.var PROGBITS +0+ +[0-9a-f]+ +[0-9a-f]+ +[0-9a-f]+ +0 +0 +(1|2|4|8) - \[00200003\]: WRITE, ALLOC, OS \(00200000\) + \[0+0800003\]: WRITE, ALLOC, OS \(0+0800000\) #pass diff --git a/binutils/testsuite/binutils-all/readelf-maskos-unknown.s b/binutils/testsuite/binutils-all/readelf-maskos-unknown.s new file mode 100644 index 0000000..b36066b --- /dev/null +++ b/binutils/testsuite/binutils-all/readelf-maskos-unknown.s @@ -0,0 +1,11 @@ + .section .data.var,"0x800003" + .global var + .type var, %object +var: + .long 2 + + .section .text._start,"ax" + .global _start + .type _start, %function +_start: + .word 0 -- cgit v1.1