From 9085a018caf2c0f27d85bc9d306a54fe390b99c2 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Tue, 23 Apr 2024 09:23:02 -0400 Subject: gdb: move symbol_file_command declaration to symfile.h Move it out of defs.h, the corresponding definition is in symfile.c. Change-Id: I984666c3bcd213f8574e9ec91462e1d61f77f16b Approved-By: Tom Tromey --- gdb/defs.h | 4 ---- gdb/symfile.c | 14 +------------- gdb/symfile.h | 16 ++++++++++++++++ 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/gdb/defs.h b/gdb/defs.h index ef5634d..8fde5be 100644 --- a/gdb/defs.h +++ b/gdb/defs.h @@ -188,10 +188,6 @@ struct value; globals that are currently only available to main.c. */ extern std::string relocate_gdb_directory (const char *initial, bool relocatable); -/* From symfile.c */ - -extern void symbol_file_command (const char *, int); - /* From top.c */ typedef void initialize_file_ftype (void); diff --git a/gdb/symfile.c b/gdb/symfile.c index b7570a3..883f1c0 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -1596,19 +1596,7 @@ validate_readnow_readnever (objfile_flags flags) error (_("-readnow and -readnever cannot be used simultaneously")); } -/* This is the symbol-file command. Read the file, analyze its - symbols, and add a struct symtab to a symtab list. The syntax of - the command is rather bizarre: - - 1. The function buildargv implements various quoting conventions - which are undocumented and have little or nothing in common with - the way things are quoted (or not quoted) elsewhere in GDB. - - 2. Options are used, which are not generally used in GDB (perhaps - "set mapped on", "set readnow on" would be better) - - 3. The order of options matters, which is contrary to GNU - conventions (because it is confusing and inconvenient). */ +/* See symfile.h. */ void symbol_file_command (const char *args, int from_tty) diff --git a/gdb/symfile.h b/gdb/symfile.h index 6f8b441..a5b0c91 100644 --- a/gdb/symfile.h +++ b/gdb/symfile.h @@ -379,4 +379,20 @@ extern int readnow_symbol_files; extern int readnever_symbol_files; +/* This is the symbol-file command. Read the file, analyze its + symbols, and add a struct symtab to a symtab list. The syntax of + the command is rather bizarre: + + 1. The function buildargv implements various quoting conventions + which are undocumented and have little or nothing in common with + the way things are quoted (or not quoted) elsewhere in GDB. + + 2. Options are used, which are not generally used in GDB (perhaps + "set mapped on", "set readnow on" would be better) + + 3. The order of options matters, which is contrary to GNU + conventions (because it is confusing and inconvenient). */ + +extern void symbol_file_command (const char *, int); + #endif /* !defined(SYMFILE_H) */ -- cgit v1.1