From 758f590744b1cf8d1049fca3223d1817242cacb8 Mon Sep 17 00:00:00 2001 From: Nick Alcock Date: Wed, 3 Feb 2021 14:09:02 +0000 Subject: libctf: add missing header in BFD ELF check Without this, GCC warns: In file included from conftest.c:36: ../../libctf/../bfd/elf-bfd.h: In function 'bfd_section_is_ctf': ../../libctf/../bfd/elf-bfd.h:3089:10: warning: implicit declaration of function 'strncmp' [-Wimplicit-function-declaration] 3089 | return strncmp (name, ".ctf", 4) == 0 && (name[4] == 0 || name[4] == '.'); | ^~~~~~~ ../../libctf/../bfd/elf-bfd.h:3089:33: warning: 'strncmp' argument 3 type is 'int' where 'long unsigned int' is expected in a call to built-in function declared without prototype [-Wbuiltin-declaration-mismatch] 3089 | return strncmp (name, ".ctf", 4) == 0 && (name[4] == 0 || name[4] == '.'); | ^ : note: built-in 'strncmp' declared here These warnings do not currently throw off the result of the configure check, but it's better to squash them anyway. libctf/ChangeLog 2021-02-03 Nick Alcock * configure.ac (ac_cv_libctf_bfd_elf): Include string.h. * configure: Regenerated. --- libctf/ChangeLog | 5 +++++ libctf/configure | 1 + libctf/configure.ac | 1 + 3 files changed, 7 insertions(+) diff --git a/libctf/ChangeLog b/libctf/ChangeLog index 135add5..cf52903 100644 --- a/libctf/ChangeLog +++ b/libctf/ChangeLog @@ -1,5 +1,10 @@ 2021-02-03 Nick Alcock + * configure.ac (ac_cv_libctf_bfd_elf): Include string.h. + * configure: Regenerated. + +2021-02-03 Nick Alcock + * configure.ac (EXPECT): Check for, in order to define... (TCL_TRY): ... this, if Tcl supports try/catch. * Makefile.am (TCL_TRY): Run the testsuite only if set. diff --git a/libctf/configure b/libctf/configure index 902eadd..d5b7861 100755 --- a/libctf/configure +++ b/libctf/configure @@ -12875,6 +12875,7 @@ else cat confdefs.h - <<_ACEOF >conftest.$ac_ext /* end confdefs.h. */ #include + #include #include "bfd.h" #include "elf-bfd.h" int diff --git a/libctf/configure.ac b/libctf/configure.ac index c6b8044..90e3c43 100644 --- a/libctf/configure.ac +++ b/libctf/configure.ac @@ -88,6 +88,7 @@ intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'` LIBS="-lbfd -liberty -lz $intl $LIBS" AC_CACHE_CHECK([for ELF support in BFD], ac_cv_libctf_bfd_elf, [AC_TRY_LINK([#include + #include #include "bfd.h" #include "elf-bfd.h"], [(void) bfd_section_from_elf_index (NULL, 0); -- cgit v1.1