Age | Commit message (Collapse) | Author | Files | Lines |
|
The generated mloop files can trigger compile time warnings. It can
be difficult to see/understand where the original code is coming from
as all the diagnostics point to the generated output. Using #line
pragmas, we can point people to the original source files.
Unfortunately, this code is written in POSIX shell, and that lacks
support for line number tracking. The $LINENO variable, even when
available, can just be plain wrong. For example, when using dash
and subshells, $LINENO can end up having negative values. Add a
wrapper script that will uses awk to rewrite the $LINENO variable
to the right value to avoid all that.
Basically lineno.sh takes an input script, rewrites all uses of
$LINENO into the actual line number (and $0 into the original file
name), and then executes the temporary script.
This commit doesn't actually add #line pragmas to any files. That
comes next.
|
|
It caught some legitimate bugs, so clearly it's helpful.
|
|
These generate conditional insns where it tests, then fallsthru.
|
|
Replace some fall through comments with the attribute.
|
|
Seems like this code was meant to fallthru.
|
|
|
|
Replace some fall through comments with the attribute.
|
|
Replace some fall through comments with the attribute.
|
|
Seems like these cases were meant to fallthru.
|
|
Seems like these decodes were intended to fallthru.
|
|
Seems like these register operations intended on falling thru.
|
|
Replace some fall through comments with the attribute.
|
|
Add the attribute where it seems to make sense.
|
|
Replace some fall through comments with the attribute.
|
|
Add the attribute to places where we want to fall thru.
|
|
Replace some fall through comments with the attribute.
|
|
Replace some fall through comments with the attribute.
|
|
Replace some fall through comments with the attribute, and add some
default abort calls when the compiler can't figure out that the set
of values were already fully enumerated in the switch statement.
|
|
Replace some fall through comments with the attribute.
|
|
We'll replace various /* fall through */ comments so compilers can
actually understand what the code is doing.
|
|
All funcs already call other funcs that don't return. The mips port is
the only exception because its generic exception handler can return in
the case of normal exceptions. So while the exceptions its signal handler
triggers doesn't return, we can't express that conditional logic. So add
some useless abort calls to make the compiler happy.
|
|
Doesn't seem like we want to cascade in this section when bit processing.
|
|
|
|
It doesn't seem like we want to keep executing the next block of code
after processing the request.
|
|
Make sure this syscall always exits regardless of the exit code.
|
|
Doesn't seem to make sense for this to fall through
(although I'm not an expert in this ISA).
|
|
Seems unlikely we want the remove syscall to fallthrough into the
rename syscall since we can't rename files that have been removed.
|
|
This helps the compiler with optimization and fixes fallthru warnings.
|
|
I don't know what this emulation does exactly, but it missing a break
statement seems kind of obvious based on the 32-bit case above it.
|
|
This helps the compiler with optimization and fixes fallthru warnings.
|
|
|
|
The compiler pointed out that we're testing LAST_TIMER_REG and
LAST_COUNTER which are the same value ... and that's because we
set LAST_TIMER_REG to the wrong register. Fix the typo.
|
|
The compiler pointed out we checked AZ twice. Sort by name to avoid
that in the future, and to make it clearer that we have coverage of
all the bits. And add the bits we were missing.
The order here doesn't matter as it's just turning a pointer into a
human readable string when store tracing is enabled.
|
|
The scache vars aren't used by ports in the pbb & fast codepaths,
nor are they documented as inputs to the callbacks, so delete them
to avoid unused variable compiler warnings.
|
|
Pull out the common parts of the genmloop invocation into the common
code. This will make it easier to add more, and make the per-port
differences a little more obvious.
|
|
Fix one minor pointer-sign warning to enable warnings in general
for this file. Reading the data as signed and then returning it
as unsigned should be functionally the same in this case.
|
|
This function only uses prev_abuf, not abuf, and doesn't inline code
from the various ports on the fly, so abuf will never be used.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|