diff options
| -rw-r--r-- | gdb/NEWS | 4 | ||||
| -rw-r--r-- | gdb/cli/cli-cmds.c | 31 | ||||
| -rw-r--r-- | gdb/doc/gdb.texinfo | 5 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.base/list.exp | 39 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.base/list1.c | 2 |
5 files changed, 78 insertions, 3 deletions
@@ -86,6 +86,10 @@ * The Ada 2022 Enum_Rep and Enum_Val attributes are now supported. +* The 'list' command now accepts '.' as an argument, which tells GDB to + print the location where the inferior is stopped. If the inferior hasn't + started yet, the command will print around the main function. + * New commands maintenance print record-instruction [ N ] diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index 00977bc..44db019 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -1234,14 +1234,14 @@ list_command (const char *arg, int from_tty) const char *p; /* Pull in the current default source line if necessary. */ - if (arg == NULL || ((arg[0] == '+' || arg[0] == '-') && arg[1] == '\0')) + if (arg == NULL || ((arg[0] == '+' || arg[0] == '-' || arg[0] == '.') && arg[1] == '\0')) { set_default_source_symtab_and_line (); symtab_and_line cursal = get_current_source_symtab_and_line (); /* If this is the first "list" since we've set the current source line, center the listing around that line. */ - if (get_first_line_listed () == 0) + if (get_first_line_listed () == 0 && (arg == nullptr || arg[0] != '.')) { list_around_line (arg, cursal); } @@ -1263,6 +1263,32 @@ list_command (const char *arg, int from_tty) print_source_lines (cursal.symtab, range, 0); } + /* "l ." lists the default location again. */ + else if (arg[0] == '.') + { + try + { + /* Find the current line by getting the PC of the currently + selected frame, and finding the line associated to it. */ + frame_info_ptr frame = get_selected_frame (nullptr); + CORE_ADDR curr_pc = get_frame_pc (frame); + cursal = find_pc_line (curr_pc, 0); + } + catch (const gdb_exception &e) + { + /* If there was an exception above, it means the inferior + is not running, so reset the current source location to + the default. */ + clear_current_source_symtab_and_line (); + set_default_source_symtab_and_line (); + cursal = get_current_source_symtab_and_line (); + } + list_around_line (arg, cursal); + /* Advance argument so just pressing "enter" after using "list ." + will print the following lines instead of the same lines again. */ + arg++; + } + return; } @@ -2770,6 +2796,7 @@ and send its output to SHELL_COMMAND.")); = add_com ("list", class_files, list_command, _("\ List specified function or line.\n\ With no argument, lists ten more lines after or around previous listing.\n\ +\"list .\" lists ten lines arond where the inferior is stopped.\n\ \"list -\" lists the ten lines before a previous ten-line listing.\n\ One argument specifies a line, and ten lines are listed around that line.\n\ Two arguments with comma between specify starting and ending lines to list.\n\ diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index b10c06a..7619efe 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -9148,6 +9148,11 @@ Stack}), this prints lines centered around that line. @item list - Print lines just before the lines last printed. + +@item list . +Print the lines surrounding the location that is where the inferior +is stopped. If the inferior is not running, print around the main +function instead. @end table @cindex @code{list}, how many lines to display diff --git a/gdb/testsuite/gdb.base/list.exp b/gdb/testsuite/gdb.base/list.exp index 18ecd13..ed178a1 100644 --- a/gdb/testsuite/gdb.base/list.exp +++ b/gdb/testsuite/gdb.base/list.exp @@ -400,6 +400,42 @@ proc test_list_invalid_args {} { "second use of \"list +INVALID\"" } +proc test_list_current_location {} { + global binfile + # If the first "list" command that GDB runs is "list ." GDB may be + # unable to recognize that the inferior isn't running, so we should + # reload the inferior to test that condition. + clean_restart + gdb_file_cmd ${binfile} + + # Ensure that we are printing 10 lines + if {![set_listsize 10]} { + return + } + + # First guarantee that GDB prints around the main function correctly + gdb_test "list ." \ + "1.*\r\n2\[ \t\]+\r\n3\[ \t\]+int main \[)(\]+.*5\[ \t\]+int x;.*" \ + "list . with inferior not running" + + if {![runto_main]} { + warning "couldn't start inferior" + return + } + + # Walk forward some lines + gdb_test "until 15" ".*15.*foo.*" + + # Test that the correct location is printed and that + # using just "list" will print the following lines. + gdb_test "list ." ".*" "list current line after starting" + gdb_test "list" ".*" "confirm we are printing the following lines" + + # Test that list . will reset to current location + gdb_test "list ." ".*" "list around current line again" + gdb_test " " ".*" "testing repeated invocations with GDB's auto-repeat" +} + clean_restart gdb_file_cmd ${binfile} @@ -519,4 +555,7 @@ test_list "list -" 10 2 "7-8" "5-6" # the current line. test_list "list -" 10 1 "7" "6" +# Test printing the location where the inferior is stopped. +test_list_current_location + remote_exec build "rm -f list0.h" diff --git a/gdb/testsuite/gdb.base/list1.c b/gdb/testsuite/gdb.base/list1.c index d694495..9297f95 100644 --- a/gdb/testsuite/gdb.base/list1.c +++ b/gdb/testsuite/gdb.base/list1.c @@ -7,7 +7,7 @@ void bar (int x) - - */ { - printf ("%d\n", x); + x++; long_line (); } |