diff options
| author | Andrew Burgess <aburgess@redhat.com> | 2022-10-19 15:19:18 +0100 |
|---|---|---|
| committer | Andrew Burgess <aburgess@redhat.com> | 2022-10-24 17:23:47 +0100 |
| commit | da8b81754bcd9eb2e45cec4997770a591cc61a8f (patch) | |
| tree | 61842b934bd32831eb31038d62c061e873ff5301 /sim/h8300 | |
| parent | 36edbb454fc9e720e723923d549b9f5356657a73 (diff) | |
| download | binutils-da8b81754bcd9eb2e45cec4997770a591cc61a8f.zip binutils-da8b81754bcd9eb2e45cec4997770a591cc61a8f.tar.gz binutils-da8b81754bcd9eb2e45cec4997770a591cc61a8f.tar.bz2 | |
sim/h8300: avoid self assignment
There are two places in the h8300 simulator where we assign a variable
to itself. Clang gives a warning for this, which is converted into an
error by -Werror.
Silence the warning by removing the self assignments. As these
assignments were in a complex if/then/else tree, rather than try to
adjust all the conditions, I've just replaced the self assignments
with a comment and an empty statement.
Diffstat (limited to 'sim/h8300')
| -rw-r--r-- | sim/h8300/compile.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sim/h8300/compile.c b/sim/h8300/compile.c index 9be7dd5..5f64b47 100644 --- a/sim/h8300/compile.c +++ b/sim/h8300/compile.c @@ -4141,7 +4141,7 @@ step_once (SIM_DESC sd, SIM_CPU *cpu) res = GET_B_REG (code->src.reg); /* FIXME fetch? */ if (!c && (0 <= (res >> 4) && (res >> 4) <= 9) && !h && (0 <= (res & 0xf) && (res & 0xf) <= 9)) - res = res; /* Value added == 0. */ + /* Nothing. */; /* Value added == 0. */ else if (!c && (0 <= (res >> 4) && (res >> 4) <= 8) && !h && (10 <= (res & 0xf) && (res & 0xf) <= 15)) res = res + 0x6; /* Value added == 6. */ @@ -4174,7 +4174,7 @@ step_once (SIM_DESC sd, SIM_CPU *cpu) res = GET_B_REG (code->src.reg); /* FIXME fetch, fetch2... */ if (!c && (0 <= (res >> 4) && (res >> 4) <= 9) && !h && (0 <= (res & 0xf) && (res & 0xf) <= 9)) - res = res; /* Value added == 0. */ + /* Nothing. */; /* Value added == 0. */ else if (!c && (0 <= (res >> 4) && (res >> 4) <= 8) && h && (6 <= (res & 0xf) && (res & 0xf) <= 15)) res = res + 0xfa; /* Value added == 0xfa. */ |