aboutsummaryrefslogtreecommitdiff
path: root/libctf
diff options
context:
space:
mode:
authorNick Alcock <nick.alcock@oracle.com>2025-04-25 21:05:02 +0100
committerNick Alcock <nick.alcock@oracle.com>2025-04-25 21:23:07 +0100
commit3aacd0f9c00bdc425d306b5de05c65b78dad944a (patch)
treec4d28b64d3a3b4deb6477d6c025fc4cfb60e5a8c /libctf
parent7bea1097ecb81cbd6fd95420798c979688acb33c (diff)
downloadbinutils-3aacd0f9c00bdc425d306b5de05c65b78dad944a.zip
binutils-3aacd0f9c00bdc425d306b5de05c65b78dad944a.tar.gz
binutils-3aacd0f9c00bdc425d306b5de05c65b78dad944a.tar.bz2
libctf: ctf-link: minor comment improvements
Diffstat (limited to 'libctf')
-rw-r--r--libctf/ctf-impl.h3
-rw-r--r--libctf/ctf-link.c13
2 files changed, 10 insertions, 6 deletions
diff --git a/libctf/ctf-impl.h b/libctf/ctf-impl.h
index 49e8ff3..92b57b3 100644
--- a/libctf/ctf-impl.h
+++ b/libctf/ctf-impl.h
@@ -333,8 +333,7 @@ typedef struct ctf_dedup
ctf_dynhash_t *cd_citers;
/* Maps type hash values to input global type IDs. The value is a set (a
- hash) of global type IDs. Discarded before each rehashing. The result of
- the ctf_dedup function. */
+ hash) of global type IDs. The result of the ctf_dedup function. */
ctf_dynhash_t *cd_output_mapping;
/* A map giving the GID of the first appearance of each type for each type
diff --git a/libctf/ctf-link.c b/libctf/ctf-link.c
index 1377251..d7927a4 100644
--- a/libctf/ctf-link.c
+++ b/libctf/ctf-link.c
@@ -487,7 +487,9 @@ ctf_link_set_memb_name_changer (ctf_dict_t *fp,
fp->ctf_link_memb_name_changer_arg = arg;
}
-/* Set a function which is used to filter out unwanted variables from the link. */
+/* Set a function which is used to filter out unwanted variables from the link.
+
+ UPTODO: call this somewhere (ctf-dedup, probably). */
int
ctf_link_set_variable_filter (ctf_dict_t *fp, ctf_link_variable_filter_f *filter,
void *arg)
@@ -544,9 +546,9 @@ ctf_link_sort_inputs (const ctf_next_hkv_t *one, const ctf_next_hkv_t *two,
}
/* Count the number of input dicts in the ctf_link_inputs, or that subset of the
- ctf_link_inputs given by CU_NAMES if set. Return the number of input dicts,
- and optionally the name and ctf_link_input_t of the single input archive if
- only one exists (no matter how many dicts it contains). */
+ ctf_link_inputs given by CU_NAMES if set: open them if need be. Return the number
+ of input dicts, and optionally the name and ctf_link_input_t of the single input
+ archive if only one exists (no matter how many dicts it contains). */
static ssize_t
ctf_link_deduplicating_count_inputs (ctf_dict_t *fp, ctf_dynhash_t *cu_names,
ctf_link_input_t **only_one_input)
@@ -1016,6 +1018,9 @@ ctf_link_deduplicating_per_cu (ctf_dict_t *fp)
uint32_t noutputs;
uint32_t *parents;
+ ctf_dprintf ("ctf_link_deduplicating_per_cu: deduplicating into %s\n",
+ out_name);
+
if ((ninputs = ctf_link_deduplicating_count_inputs (fp, in,
&only_input)) == -1)
goto err_open_inputs;