aboutsummaryrefslogtreecommitdiff
path: root/gdb
diff options
context:
space:
mode:
authorDoug Evans <dje@google.com>2015-01-29 10:31:21 -0800
committerDoug Evans <dje@google.com>2015-01-29 10:31:21 -0800
commit0a3f9dcee8f15d634b742ad69d3c78a067a1ed2c (patch)
tree152d2f108704b424eb0c9562309b238440c2c068 /gdb
parentdd25c4e757b07110efce8680ad530a4388f9d660 (diff)
downloadbinutils-0a3f9dcee8f15d634b742ad69d3c78a067a1ed2c.zip
binutils-0a3f9dcee8f15d634b742ad69d3c78a067a1ed2c.tar.gz
binutils-0a3f9dcee8f15d634b742ad69d3c78a067a1ed2c.tar.bz2
PR symtab/17890
gdb/ChangeLog: PR symtab/17890 * dwarf2read.c (dwarf_decode_line_header): Punt if version > 4.
Diffstat (limited to 'gdb')
-rw-r--r--gdb/ChangeLog5
-rw-r--r--gdb/dwarf2read.c10
2 files changed, 15 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 98ec3b7..330bffe 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2015-01-29 Doug Evans <dje@google.com>
+
+ PR symtab/17890
+ * dwarf2read.c (dwarf_decode_line_header): Punt if version > 4.
+
2015-01-26 Wei-cheng Wang <cole945@gmail.com>
Backport from mainline:
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index f1f24c6..89119b3 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -17117,6 +17117,8 @@ get_debug_line_section (struct dwarf2_cu *cu)
/* Read the statement program header starting at OFFSET in
.debug_line, or .debug_line.dwo. Return a pointer
to a struct line_header, allocated using xmalloc.
+ Returns NULL if there is a problem reading the header, e.g., if it
+ has a version we don't understand.
NOTE: the strings in the include directory and file name tables of
the returned object point into the dwarf line section buffer,
@@ -17181,6 +17183,14 @@ dwarf_decode_line_header (unsigned int offset, struct dwarf2_cu *cu)
lh->statement_program_end = line_ptr + lh->total_length;
lh->version = read_2_bytes (abfd, line_ptr);
line_ptr += 2;
+ if (lh->version > 4)
+ {
+ /* This is a version we don't understand. The format could have
+ changed in ways we don't handle properly so just punt. */
+ complaint (&symfile_complaints,
+ _("unsupported version in .debug_line section"));
+ return NULL;
+ }
lh->header_length = read_offset_1 (abfd, line_ptr, offset_size);
line_ptr += offset_size;
lh->minimum_instruction_length = read_1_byte (abfd, line_ptr);