gdb: add field::name / field::set_name

Add the `name` and `set_name` methods on `struct field`, in order to
remove `FIELD_NAME` and `TYPE_FIELD_NAME` macros.  In this patch, the
macros are changed to use `field::name`, so all the call sites that are
used to set the field's name are changed to use `field::set_name`.
The next patch will remove the macros completely.

Note that because of the name clash between the existing field named
`name` and the new method, I renamed the field `m_name`.  It is not
private per-se, because we can't make `struct field` a non-POD yet, but
it should be considered private anyway (not accessed outside `struct
field`).

Change-Id: If16ddbca4e0c39d0ff9da420bb5cdebe5b9b0896

1 files changed, 1 insertions, 1 deletions

diff --git a/gdb/windows-tdep.c b/gdb/windows-tdep.c
index 8e8bc1c..c79d5e2 100644
--- a/gdb/windows-tdep.c
+++ b/gdb/windows-tdep.c
@@ -761,7 +761,7 @@ create_enum (struct gdbarch *gdbarch, int bit, const char *name,
 
   for (i = 0; i < count; i++)
     {
-      TYPE_FIELD_NAME (type, i) = values[i].name;
+      type->field (i).set_name (values[i].name);
       SET_FIELD_ENUMVAL (type->field (i), values[i].value);
     }