diff options
| author | Tom Tromey <tom@tromey.com> | 2021-08-26 18:17:40 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2021-09-24 11:58:04 -0600 |
| commit | 7ebaa5f7821682c40e79ee1fdfe43528b7d87376 (patch) | |
| tree | e32d94cab5616bedf19aa1637eaea7e1c0df49fb /gdb/value.h | |
| parent | 604386598d43e50f183aba65189354e04ffbdda3 (diff) | |
| download | binutils-7ebaa5f7821682c40e79ee1fdfe43528b7d87376.zip binutils-7ebaa5f7821682c40e79ee1fdfe43528b7d87376.tar.gz binutils-7ebaa5f7821682c40e79ee1fdfe43528b7d87376.tar.bz2 | |
Move value_true to value.h
I noticed that value_true is declared in language.h and defined in
language.c. However, as part of the value API, I think it would be
better in one of those files. And, because it is very short, I
changed it to be an inline function in value.h. I've also removed a
comment from the implementation, on the basis that it seems obsolete
-- if the change it suggests was needed, it probably would have been
done by now; and if it is needed in the future, odds are it would be
done differently anyway.
Finally, this patch also changes value_true and value_logical_not to
return a bool, and updates some uses.
Diffstat (limited to 'gdb/value.h')
| -rw-r--r-- | gdb/value.h | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/gdb/value.h b/gdb/value.h index e1c6aab..3f00444 100644 --- a/gdb/value.h +++ b/gdb/value.h @@ -1022,7 +1022,15 @@ extern int value_equal_contents (struct value *arg1, struct value *arg2); extern int value_less (struct value *arg1, struct value *arg2); -extern int value_logical_not (struct value *arg1); +/* Simulate the C operator ! -- return true if ARG1 contains zero. */ +extern bool value_logical_not (struct value *arg1); + +/* Returns true if the value VAL represents a true value. */ +static inline bool +value_true (struct value *val) +{ + return !value_logical_not (val); +} /* C++ */ |