diff options
author | Pedro Alves <palves@redhat.com> | 2017-09-04 18:23:22 +0100 |
---|---|---|
committer | Pedro Alves <palves@redhat.com> | 2017-09-04 18:23:22 +0100 |
commit | 9a24775b97646827396073d0d7e510b9694331ab (patch) | |
tree | d360279777f8163d750f17c01507fc671e24b4b6 /gdb/target-debug.h | |
parent | 9521ecda6835b338d61b1b06e1a91706711b1d0b (diff) | |
download | binutils-9a24775b97646827396073d0d7e510b9694331ab.zip binutils-9a24775b97646827396073d0d7e510b9694331ab.tar.gz binutils-9a24775b97646827396073d0d7e510b9694331ab.tar.bz2 |
Introduce gdb_disassembly_flags
For some reason I ended up staring at some of the "int flags" in
btrace-related code, and I got confused because I had no clue what the
flags where supposed to indicate.
Fix that by using enum_flags, so that:
#1 - it's clear from the type what the flags are about, and
#2 - the compiler can catch mismatching mistakes
gdb/ChangeLog:
2017-09-04 Pedro Alves <palves@redhat.com>
* cli/cli-cmds.c (print_disassembly, disassemble_current_function)
(disassemble_command): Use gdb_disassembly_flags instead of bare
int.
* disasm.c (gdb_pretty_print_disassembler::pretty_print_insn)
(dump_insns, do_mixed_source_and_assembly_deprecated)
(do_mixed_source_and_assembly, do_assembly_only, gdb_disassembly):
Use gdb_disassembly_flags instead of bare int.
* disasm.h (DISASSEMBLY_SOURCE_DEPRECATED, DISASSEMBLY_RAW_INSN)
(DISASSEMBLY_OMIT_FNAME, DISASSEMBLY_FILENAME)
(DISASSEMBLY_OMIT_PC, DISASSEMBLY_SOURCE)
(DISASSEMBLY_SPECULATIVE): No longer macros. Instead they're...
(enum gdb_disassembly_flag): ... values of this new enumeration.
(gdb_disassembly_flags): Define.
(gdb_disassembly)
(gdb_pretty_print_disassembler::pretty_print_insn): Use it.
* mi/mi-cmd-disas.c (mi_cmd_disassemble): Use
gdb_disassembly_flags instead of bare int.
* record-btrace.c (btrace_insn_history)
(record_btrace_insn_history, record_btrace_insn_history_range)
(record_btrace_insn_history_from): Use gdb_disassembly_flags
instead of bare int.
* record.c (get_insn_history_modifiers, cmd_record_insn_history):
Use gdb_disassembly_flags instead of bare int.
* target-debug.h (target_debug_print_gdb_disassembly_flags):
Define.
* target-delegates.c: Regenerate.
* target.c (target_insn_history, target_insn_history_from)
(target_insn_history_range): Use gdb_disassembly_flags instead of
bare int.
* target.h: Include "disasm.h".
(struct target_ops) <to_insn_history, to_insn_history_from,
to_insn_history_range>: Use gdb_disassembly_flags instead of bare
int.
(target_insn_history, target_insn_history_from)
(target_insn_history_range): Use gdb_disassembly_flags instead of
bare int.
Diffstat (limited to 'gdb/target-debug.h')
-rw-r--r-- | gdb/target-debug.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/gdb/target-debug.h b/gdb/target-debug.h index 532e98d..7477ce6 100644 --- a/gdb/target-debug.h +++ b/gdb/target-debug.h @@ -162,6 +162,8 @@ target_debug_do_print (host_address_to_string (X)) #define target_debug_print_enum_remove_bp_reason(X) \ target_debug_do_print (plongest (X)) +#define target_debug_print_gdb_disassembly_flags(X) \ + target_debug_do_print (plongest (X)) static void target_debug_print_struct_target_waitstatus_p (struct target_waitstatus *status) |