diff options
| author | Pedro Alves <pedro@palves.net> | 2022-05-16 17:30:06 +0100 |
|---|---|---|
| committer | Pedro Alves <pedro@palves.net> | 2022-05-20 20:41:02 +0100 |
| commit | 74421c0bc857fdeadd033b44bb3cd372df8d62b8 (patch) | |
| tree | e4d8151723478f699eb09e1c4fedce95510b4a9b /gdb/symtab.h | |
| parent | 46f0aab14350e9e380c6bbe7bf0539932241fb5b (diff) | |
| download | binutils-74421c0bc857fdeadd033b44bb3cd372df8d62b8.zip binutils-74421c0bc857fdeadd033b44bb3cd372df8d62b8.tar.gz binutils-74421c0bc857fdeadd033b44bb3cd372df8d62b8.tar.bz2 | |
Rename base_breakpoint -> code_breakpoint
Even after the previous patches reworking the inheritance of several
breakpoint types, the present breakpoint hierarchy looks a bit
surprising, as we have "breakpoint" as the superclass, and then
"base_breakpoint" inherits from "breakpoint". Like so, simplified:
breakpoint
base_breakpoint
ordinary_breakpoint
internal_breakpoint
momentary_breakpoint
ada_catchpoint
exception_catchpoint
tracepoint
watchpoint
catchpoint
exec_catchpoint
...
The surprising part to me is having "base_breakpoint" being a subclass
of "breakpoint". I'm just refering to naming here -- I mean, you'd
expect that it would be the top level baseclass that would be called
"base".
Just flipping the names of breakpoint and base_breakpoint around
wouldn't be super great for us, IMO, given we think of every type of
*point as a breakpoint at the user visible level. E.g., "info
breakpoints" shows watchpoints, tracepoints, etc. So it makes to call
the top level class breakpoint.
Instead, I propose renaming base_breakpoint to code_breakpoint. The
previous patches made sure that all code breakpoints inherit from
base_breakpoint, so it's fitting. Also, "code breakpoint" contrasts
nicely with a watchpoint also being typically known as a "data
breakpoint".
After this commit, the resulting hierarchy looks like:
breakpoint
code_breakpoint
ordinary_breakpoint
internal_breakpoint
momentary_breakpoint
ada_catchpoint
exception_catchpoint
tracepoint
watchpoint
catchpoint
exec_catchpoint
...
... which makes a lot more sense to me.
I've left this patch as last in the series in case people want to
bikeshed on the naming.
"code" has a nice property that it's exactly as many letters as
"base", so this patch didn't require any reindentation. :-)
Change-Id: Id8dc06683a69fad80d88e674f65e826d6a4e3f66
Diffstat (limited to 'gdb/symtab.h')
| -rw-r--r-- | gdb/symtab.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/gdb/symtab.h b/gdb/symtab.h index 5218be5..ac902a4 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -55,7 +55,7 @@ struct obj_section; struct cmd_list_element; class probe; struct lookup_name_info; -struct base_breakpoint; +struct code_breakpoint; /* How to match a lookup name against a symbol search name. */ enum class symbol_name_match_type @@ -2228,10 +2228,10 @@ struct gnu_ifunc_fns CORE_ADDR *function_address_p); /* See elf_gnu_ifunc_resolver_stop for its real implementation. */ - void (*gnu_ifunc_resolver_stop) (base_breakpoint *b); + void (*gnu_ifunc_resolver_stop) (code_breakpoint *b); /* See elf_gnu_ifunc_resolver_return_stop for its real implementation. */ - void (*gnu_ifunc_resolver_return_stop) (base_breakpoint *b); + void (*gnu_ifunc_resolver_return_stop) (code_breakpoint *b); }; #define gnu_ifunc_resolve_addr gnu_ifunc_fns_p->gnu_ifunc_resolve_addr |