diff options
| author | Simon Marchi <simon.marchi@efficios.com> | 2023-10-02 16:00:55 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@efficios.com> | 2023-10-19 10:57:51 -0400 |
| commit | e3b63a7910ac7a4ee959af20a544075becbf2671 (patch) | |
| tree | e881e11f0ee8feac2acd083cb4f1eb69e3d64c63 /gdb/solib-target.c | |
| parent | ae4bf24404a134d96bc1844fc949ca518df698f8 (diff) | |
| download | binutils-e3b63a7910ac7a4ee959af20a544075becbf2671.zip binutils-e3b63a7910ac7a4ee959af20a544075becbf2671.tar.gz binutils-e3b63a7910ac7a4ee959af20a544075becbf2671.tar.bz2 | |
gdb: remove target_so_ops::free_so
target_so_ops::free_so is responsible for freeing the specific lm_info
object. All implementations basically just call delete. Remove that
method, make the destructor of lm_info virtual, and call delete directly
from the free_so function. Make the sub-classes final, just because
it's good practice.
Change-Id: Iee1fd4861c75034a9e41a656add8ed8dfd8964ee
Approved-By: Pedro Alves <pedro@palves.net>
Reviewed-By: Reviewed-By: Lancelot Six <lancelot.six@amd.com>
Diffstat (limited to 'gdb/solib-target.c')
| -rw-r--r-- | gdb/solib-target.c | 13 |
1 files changed, 1 insertions, 12 deletions
diff --git a/gdb/solib-target.c b/gdb/solib-target.c index 8e6a440..f79b59a 100644 --- a/gdb/solib-target.c +++ b/gdb/solib-target.c @@ -28,7 +28,7 @@ #include "inferior.h" /* Private data for each loaded library. */ -struct lm_info_target : public lm_info +struct lm_info_target final : public lm_info { /* The library's name. The name is normally kept in the struct so_list; it is only here during XML parsing. */ @@ -282,16 +282,6 @@ solib_target_solib_create_inferior_hook (int from_tty) } static void -solib_target_free_so (so_list &so) -{ - lm_info_target *li = (lm_info_target *) so.lm_info; - - gdb_assert (li->name.empty ()); - - delete li; -} - -static void solib_target_relocate_section_addresses (so_list &so, target_section *sec) { CORE_ADDR offset; @@ -431,7 +421,6 @@ solib_target_in_dynsym_resolve_code (CORE_ADDR pc) const struct target_so_ops solib_target_so_ops = { solib_target_relocate_section_addresses, - solib_target_free_so, nullptr, nullptr, solib_target_solib_create_inferior_hook, |