diff options
| author | Tom Tromey <tromey@adacore.com> | 2024-09-11 10:35:20 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2024-09-23 13:44:59 -0600 |
| commit | 336bb2a1c1d24f5db07394a109f7cd6c5b58b10d (patch) | |
| tree | 5a8d54ecc8d127a2113712203f1c66aa9c5d8c0e /gdb/python/py-unwind.c | |
| parent | b9155b800c6be57a7f4933a4fd8c5c5d51414e77 (diff) | |
| download | binutils-336bb2a1c1d24f5db07394a109f7cd6c5b58b10d.zip binutils-336bb2a1c1d24f5db07394a109f7cd6c5b58b10d.tar.gz binutils-336bb2a1c1d24f5db07394a109f7cd6c5b58b10d.tar.bz2 | |
Automatically add types to Python modules
PR python/32163 points out that various types provided by gdb are not
added to the gdb module, so they aren't available for interactive
inspection. I think this is just an oversight.
This patch fixes the problem by introducing a new helper function that
both readies the type and then adds it to the appropriate module. The
patch also poisons PyType_Ready, the idea being to avoid this bug in
the future.
v2:
* Fixed a bug in original patch in gdb.Architecture registration
* Added regression test for the types mentioned in the bug
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32163
Reviewed-By: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
Diffstat (limited to 'gdb/python/py-unwind.c')
| -rw-r--r-- | gdb/python/py-unwind.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/gdb/python/py-unwind.c b/gdb/python/py-unwind.c index e36768e..a10a758 100644 --- a/gdb/python/py-unwind.c +++ b/gdb/python/py-unwind.c @@ -1002,17 +1002,13 @@ gdbpy_initialize_unwind (void) { gdb::observers::new_architecture.attach (pyuw_on_new_gdbarch, "py-unwind"); - if (PyType_Ready (&pending_frame_object_type) < 0) + if (gdbpy_type_ready (&pending_frame_object_type) < 0) return -1; - int rc = gdb_pymodule_addobject (gdb_module, "PendingFrame", - (PyObject *) &pending_frame_object_type); - if (rc != 0) - return rc; - if (PyType_Ready (&unwind_info_object_type) < 0) + if (gdbpy_type_ready (&unwind_info_object_type) < 0) return -1; - return gdb_pymodule_addobject (gdb_module, "UnwindInfo", - (PyObject *) &unwind_info_object_type); + + return 0; } void _initialize_py_unwind (); |