aboutsummaryrefslogtreecommitdiff
path: root/gdb/python/py-micmd.c
diff options
context:
space:
mode:
authorLuis Machado <luis.machado@arm.com>2022-01-04 14:06:36 -0300
committerLuis Machado <luis.machado@arm.com>2022-03-14 10:38:32 +0000
commitbab22d0640914384d467e09c3e796585fd08e7c6 (patch)
tree96c9d0148f50a7686eab88239889a1d3c7b782a7 /gdb/python/py-micmd.c
parentd4661bf0e978da6e8b8a9cb792c9e82bfab403f0 (diff)
downloadbinutils-bab22d0640914384d467e09c3e796585fd08e7c6.zip
binutils-bab22d0640914384d467e09c3e796585fd08e7c6.tar.gz
binutils-bab22d0640914384d467e09c3e796585fd08e7c6.tar.bz2
[aarch64/arm] Properly extract the return value returned in memory
When running gdb.cp/non-trivial-retval.exp, the following shows up for both aarch64-linux and armhf-linux: Breakpoint 3, f1 (i1=23, i2=100) at src/gdb/testsuite/gdb.cp/non-trivial-retval.cc:35 35 A a; (gdb) finish Run till exit from #0 f1 (i1=23, i2=100) at src/gdb/testsuite/gdb.cp/non-trivial-retval.cc:35 main () at /src/gdb/testsuite/gdb.cp/non-trivial-retval.cc:163 163 B b = f2 (i1, i2); Value returned is $6 = {a = -11952} (gdb) The return value should be {a = 123} instead. This happens because the backends don't extract the return value from the correct location. GDB should fetch a pointer to the memory location from X8 for aarch64 and r0 for armhf. With the patch, gdb.cp/non-trivial-retval.exp has full passes on aarch64-linux and armhf-linux on Ubuntu 20.04/18.04. The problem only shows up with the "finish" command. The "call" command works correctly and displays the correct return value. This is also related to PR gdb/28681 (https://sourceware.org/bugzilla/show_bug.cgi?id=28681) and fixes FAIL's in gdb.ada/mi_var_array.exp. A new testcase is provided, and it exercises GDB's ability to "finish" a function that returns a large struct (> 16 bytes) and display the contents of this struct correctly. This has always been incorrect for these backends, but no testcase exercised this particular scenario.
Diffstat (limited to 'gdb/python/py-micmd.c')
0 files changed, 0 insertions, 0 deletions