diff options
| author | Tom Tromey <tom@tromey.com> | 2023-02-16 17:52:07 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2023-02-17 19:05:04 -0500 |
| commit | e8eca7a6b602290bb3f50728432d524577ade727 (patch) | |
| tree | 690c77570707426db4dd123ca09d645bca0c0f3f /gdb/go-lang.c | |
| parent | be643e074f3081b537a11c87c1ccf1d400f2945e (diff) | |
| download | binutils-e8eca7a6b602290bb3f50728432d524577ade727.zip binutils-e8eca7a6b602290bb3f50728432d524577ade727.tar.gz binutils-e8eca7a6b602290bb3f50728432d524577ade727.tar.bz2 | |
Fix crash in go_symbol_package_name
go_symbol_package_name package name asserts that it is only passed a
Go symbol, but this is not enforced by one caller. It seems simplest
to just check and return early in this case.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=17876
Reviewed-By: Andrew Burgess <aburgess@redhat.com>
Diffstat (limited to 'gdb/go-lang.c')
| -rw-r--r-- | gdb/go-lang.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/gdb/go-lang.c b/gdb/go-lang.c index f9176ac..bbf80af 100644 --- a/gdb/go-lang.c +++ b/gdb/go-lang.c @@ -394,7 +394,8 @@ go_symbol_package_name (const struct symbol *sym) int method_type_is_pointer; gdb::unique_xmalloc_ptr<char> name_buf; - gdb_assert (sym->language () == language_go); + if (sym->language () != language_go) + return nullptr; name_buf = unpack_mangled_go_symbol (mangled_name, &package_name, &object_name, &method_type_package_name, |