diff options
| author | Tom Tromey <tom@tromey.com> | 2022-04-26 12:45:07 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2022-04-28 09:37:48 -0600 |
| commit | 9dd9f9ce1e231ef594845f11c05a724653241b58 (patch) | |
| tree | 6748568e879ce123e0bcd2736d724b2b2771ce56 /gdb/dwarf2/index-write.c | |
| parent | 0d1703b8fb611f978577a70ad6aa308a12a53980 (diff) | |
| download | binutils-9dd9f9ce1e231ef594845f11c05a724653241b58.zip binutils-9dd9f9ce1e231ef594845f11c05a724653241b58.tar.gz binutils-9dd9f9ce1e231ef594845f11c05a724653241b58.tar.bz2 | |
Check OBJF_NOT_FILENAME in DWARF index code
The DWARF index code currently uses 'stat' to see if an objfile
represents a real file. However, I think it's more correct to check
OBJF_NOT_FILENAME instead.
Regression tested on x86-64 Fedora 34.
Diffstat (limited to 'gdb/dwarf2/index-write.c')
| -rw-r--r-- | gdb/dwarf2/index-write.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/gdb/dwarf2/index-write.c b/gdb/dwarf2/index-write.c index afe55da..3d1c78d 100644 --- a/gdb/dwarf2/index-write.c +++ b/gdb/dwarf2/index-write.c @@ -1411,9 +1411,8 @@ write_dwarf_index (dwarf2_per_objfile *per_objfile, const char *dir, if (per_objfile->per_bfd->types.size () > 1) error (_("Cannot make an index when the file has multiple .debug_types sections")); - struct stat st; - if (stat (objfile_name (objfile), &st) < 0) - perror_with_name (objfile_name (objfile)); + + gdb_assert ((objfile->flags & OBJF_NOT_FILENAME) == 0); const char *index_suffix = (index_kind == dw_index_kind::DEBUG_NAMES ? INDEX5_SUFFIX : INDEX4_SUFFIX); @@ -1472,10 +1471,8 @@ save_gdb_index_command (const char *arg, int from_tty) for (objfile *objfile : current_program_space->objfiles ()) { - struct stat st; - /* If the objfile does not correspond to an actual file, skip it. */ - if (stat (objfile_name (objfile), &st) < 0) + if ((objfile->flags & OBJF_NOT_FILENAME) != 0) continue; dwarf2_per_objfile *per_objfile = get_dwarf2_per_objfile (objfile); |